Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] Increment version to 2.10.0.0 #1526

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

  • Incremented version to 2.10.0.0.

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
@cwperks
Copy link
Member

cwperks commented Aug 1, 2023

Looks like selenium may need to be updated.

error selenium-webdriver@4.11.0: The engine "node" is incompatible with this module. Expected version ">= 14.20.0". Got "14.19.1"
error Found incompatible module.

@cwperks
Copy link
Member

cwperks commented Aug 1, 2023

There's an issue in the logic to extract the version now that 2.x is in double digits.

https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/actions/install-dashboards/action.yml#L41-L46

It's trying to checkout 2.1 when it should be trying for 2.10...

@cwperks
Copy link
Member

cwperks commented Aug 1, 2023

It may be possible to replace the cut command with | tr -d '"' to string the double quotes

"2.10.0" becomes 2.10.0

Edit:

  1. For the first command echo "::set-output name=osd-version::, the GHA expects an output like a branch name. i.e. 2.10.

  2. For the second command echo "::set-output name=osd-x-version::, the GHA expects an output with the major version and a period. i.e 2.

@RyanL1997
Copy link
Collaborator

Closing this and merge this into the version regex fix: #1533

@RyanL1997 RyanL1997 closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants