Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oui Security Dashboards Changes #1531

Closed

Conversation

stephen-crawford
Copy link
Contributor

@stephen-crawford stephen-crawford commented Aug 1, 2023

Description

This PR addresses the changes requested by the OpenSearch Dashboards team for the release of OUI.

Category

Enhancement

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1531 (72e8888) into main (91faa3d) will decrease coverage by 0.08%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
- Coverage   66.06%   65.99%   -0.08%     
==========================================
  Files          93       93              
  Lines        2328     2332       +4     
  Branches      310      310              
==========================================
+ Hits         1538     1539       +1     
- Misses        722      725       +3     
  Partials       68       68              
Files Changed Coverage Δ
...nels/audit-logging/audit-logging-edit-settings.tsx 78.43% <25.00%> (-4.55%) ⬇️

@stephen-crawford
Copy link
Contributor Author

stephen-crawford commented Aug 1, 2023

Screenshot 2023-08-01 at 3 39 35 PM

SVG just not showing up in dark mode?

Audi logs look good:

Screenshot 2023-08-01 at 3 41 07 PM

Definitely the new SVG that is the issue since the old one still shows up:

Screenshot 2023-08-01 at 3 46 04 PM

@stephen-crawford
Copy link
Contributor Author

stephen-crawford commented Aug 1, 2023

Screenshot 2023-08-01 at 4 05 56 PM

I made this^
Edit: It is invisible in light mode....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant