Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force resolution of selenium-webdriver to 4.10.0 #1541

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Force resolution of selenium-webdriver to 4.10.0 #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,15 @@
"gulp-rename": "2.0.0",
"jose": "^4.11.2",
"saml-idp": "^1.2.1",
"selenium-webdriver": "^4.0.0-alpha.7",
"selfsigned": "^2.0.1",
"typescript": "4.0.2"
},
"dependencies": {
"@hapi/cryptiles": "5.0.0",
"@hapi/wreck": "^17.1.0",
"html-entities": "1.3.1"
},
"resolutions": {
"selenium-webdriver": "4.10.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Was there any pkgs dpending on the selenium-webdriver with different versions? Just trying to figure out why we are using the selective dependencies resolution here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is forcing to 4.10.0 due to a suspected bug in selenium. See the versions here: https://www.npmjs.com/package/selenium-webdriver?activeTab=versions

4.11.0 was published 3 days ago and 4.11.1 2 days ago. We can try removing this forced resolution on future versions of selenium. I'm going to look through the selenium issue list to look for any known issues: https://github.com/SeleniumHQ/selenium/issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the error comes from this PR in Selenium, but I don't know enough about selenium to be able to determine why it produces the error we are seeing.

}
}
Loading