Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main] Check in yarn.lock file in its current state and update cypress to version 13.6.0 #1668

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Nov 28, 2023

Description

This PR removes yarn.lock from gitignore, and checks in the current version of the generated yarn.lock file, after running yarn install. Yarn.lock provides a few benefits:

  • Provides reproducibility, by being a source of truth for which versions of each dependency were downloaded. This also allows for debugging - if package.json specifies ^1.2.0, you could be using 1.2.0, 1.2.1, etc.
  • Includes integrity hash to make sure you are downloading from a trusted source

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec661f8) 67.06% compared to head (43557d7) 67.06%.

❗ Current head 43557d7 differs from pull request most recent head 87941a3. Consider uploading reports for the commit 87941a3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files          94       94           
  Lines        2402     2402           
  Branches      318      318           
=======================================
  Hits         1611     1611           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho derek-ho changed the title Check in yarn.lock file in its current state [Main] Check in yarn.lock file in its current state Nov 28, 2023
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
cwperks previously approved these changes Nov 28, 2023
@RyanL1997
Copy link
Collaborator

Updating branch due to the merge of #1579

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Collaborator

RyanL1997 commented Nov 29, 2023

Hi @derek-ho, I just pushed another commit to include the latest Cypress 13 and update the yarn lock file.

@RyanL1997 RyanL1997 changed the title [Main] Check in yarn.lock file in its current state [Main] Check in yarn.lock file in its current state and update cypress to version 13.6.0 Nov 29, 2023
@RyanL1997 RyanL1997 merged commit eb55ae8 into opensearch-project:main Dec 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants