Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cookie expiry issues from IDP/JWT auth methods, disables keepalive for JWT/IDP #1773

Merged
merged 31 commits into from
Feb 23, 2024
Merged

Fix cookie expiry issues from IDP/JWT auth methods, disables keepalive for JWT/IDP #1773

merged 31 commits into from
Feb 23, 2024

Commits on Feb 8, 2024

  1. Fix SAML timeout issues when keepalive is true 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    183b502 View commit details
    Browse the repository at this point in the history

  2. lint 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a1848b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Fix oidc flow 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9afd31e View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge branch 'main' of github.com:opensearch-project/security-dashboa… 

    …rds-plugin into idp-timeout
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    b621d10 View commit details
    Browse the repository at this point in the history

  2. Add keep alive test 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1da9739 View commit details
    Browse the repository at this point in the history

  3. Lint 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    cf0b857 View commit details
    Browse the repository at this point in the history

  4. Add openid valid cookie test 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    bc96a3f View commit details
    Browse the repository at this point in the history

  5. Push up stale work 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    5883c80 View commit details
    Browse the repository at this point in the history

  6. remove const assignment 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    278c40d View commit details
    Browse the repository at this point in the history

  7. Introduce abstract method to block jwt implementations from keep alive 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    364827f View commit details
    Browse the repository at this point in the history

  8. Lint 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8e3f434 View commit details
    Browse the repository at this point in the history

  9. Fix compile issues 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    cf2b4ae View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Fix warnings 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    52fd304 View commit details
    Browse the repository at this point in the history

  2. Lint 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b9528e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Add test for JWT and fix warnings 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    1202368 View commit details
    Browse the repository at this point in the history

  2. Remove unused testing code 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    934ca76 View commit details
    Browse the repository at this point in the history

  3. Remove test after PR changed 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    804cce7 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge branch 'main' of github.com:opensearch-project/security-dashboa… 

    …rds-plugin into idp-timeout
    @derek-ho
    derek-ho committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3b1d5d3 View commit details
    Browse the repository at this point in the history

  2. Refactor keep alive for JWT and no-op for SAML, OIDC 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    529ded1 View commit details
    Browse the repository at this point in the history

  3. Lint 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0549a52 View commit details
    Browse the repository at this point in the history

  4. Refactor test for readability 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ace02e2 View commit details
    Browse the repository at this point in the history

  5. Add tests for each auth type 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6b76c4c View commit details
    Browse the repository at this point in the history

  6. Fix test to make it clear that it is taking value from date.now + ttl 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    275d569 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Remove console log 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    40878d8 View commit details
    Browse the repository at this point in the history

  2. PR feedback 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    30ff169 View commit details
    Browse the repository at this point in the history

  3. Lint 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4c1e448 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Test fixes 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1c542fc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into idp-timeout

    @derek-ho
    derek-ho authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8721eef View commit details
    Browse the repository at this point in the history

  3. Fix variable names 

    Signed-off-by: Derek Ho <dxho@amazon.com>
    @derek-ho
    derek-ho committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d426aae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:opensearch-project/security-dashboa… 

    …rds-plugin into idp-timeout
    @derek-ho
    derek-ho committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    da0f7b9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'idp-timeout' of github.com:derek-ho/security-dashboards… 

    …-plugin into idp-timeout
    @derek-ho
    derek-ho committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5e7e45b View commit details
    Browse the repository at this point in the history