[Backport 2.x] Use start-opensearch and setup-opensearch-dashboards actions #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch-project#1783) * Revert to old version Signed-off-by: Derek Ho <dxho@amazon.com> * Fix order Signed-off-by: Derek Ho <dxho@amazon.com> * Revert deletion of custom dashboards file Signed-off-by: Derek Ho <dxho@amazon.com> * Replace other instances of the backend workflow Signed-off-by: Derek Ho <dxho@amazon.com> * Add file prefix Signed-off-by: Derek Ho <dxho@amazon.com> * Also add env variable references in workflow Signed-off-by: Derek Ho <dxho@amazon.com> * Try the branch that adds settings for security dashboards ci support Signed-off-by: Derek Ho <dxho@amazon.com> * Update workflow to v2 Signed-off-by: Derek Ho <dxho@amazon.com> * Use setup opensearch dashboards workflow Signed-off-by: Derek Ho <dxho@amazon.com> * Remove duplciate functionality in binary installation Signed-off-by: Derek Ho <dxho@amazon.com> * Unsaved local changes Signed-off-by: Derek Ho <dxho@amazon.com> * install zip as true Signed-off-by: Derek Ho <dxho@amazon.com> * Consolidate writing yml file Signed-off-by: Derek Ho <dxho@amazon.com> * Remove duplicate install Signed-off-by: Derek Ho <dxho@amazon.com> * Modify workflow to pass in built plugin artifact name Signed-off-by: Derek Ho <dxho@amazon.com> * Use latest version of workflow and use directory output Signed-off-by: Derek Ho <dxho@amazon.com> * Fix syntax issue Signed-off-by: Derek Ho <dxho@amazon.com> * Run start dashboards command in correct directory Signed-off-by: Derek Ho <dxho@amazon.com> * Use v1 release Signed-off-by: Derek Ho <dxho@amazon.com> * Remove cats and rename config files Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 9516bea) Signed-off-by: Derek Ho <dxho@amazon.com>
…ds-plugin into backport/backport-1783-to-2.x Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1808 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 93 93
Lines 2358 2358
Branches 314 314
=======================================
Hits 1582 1582
Misses 699 699
Partials 77 77 ☔ View full report in Codecov by Sentry. |
peternied
approved these changes
Feb 26, 2024
DarshitChanpura
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstracts actions to use start-opensearch and setup-opensearch-dashboards actions so code can be re-used across the org. Also workflows were removed from security plugin so this is necessary to unblock the 2.x CI.
Category
Backport from main
Why these changes are required?
Backport from main
What is the old behavior before changes and new behavior after changes?
N/A no behavior change
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Backport of #1783
Testing
Github actions continue to succeed
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.