Support multi datasources on service accounts page #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997 and
stephen-crawford
as code owners
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1870 +/- ##
===========================================================================
- Coverage 68.25% 68.23% -0.03%
===========================================================================
Files 96 96
Lines 2448 2449 +1
Branches 332 332
===========================================================================
Hits 1671 1671
- Misses 698 699 +1
Partials 79 79 ☔ View full report in Codecov by Sentry. |
DarshitChanpura
approved these changes
Apr 4, 2024
DarshitChanpura
merged commit 0a57e75
into
opensearch-project:feature/supporting-multiple-datasources
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds selector on service accounts tab
Category
Enhancement
Why these changes are required?
Support multi datasources in the service accounts tab
What is the old behavior before changes and new behavior after changes?
Selector is introduced with read only behavior to the local cluster. Since this tab does not exist in 2.x line, I kept the changes minimal.
Issues Resolved
#1799
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.