Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Fix a bug where basepath nextUrl is invalid when it should be valid #2098

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b1148fb from #2096.

…2096)

* Fix a bug where basepath nextUrl is invalid when it should be valid

Signed-off-by: Derek Ho <dxho@amazon.com>

* Udpate test

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit b1148fb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.48%. Comparing base (053e088) to head (6cacd36).
Report is 1 commits behind head on 1.3.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.3    #2098   +/-   ##
=======================================
  Coverage   72.48%   72.48%           
=======================================
  Files          88       88           
  Lines        1926     1926           
  Branches      251      251           
=======================================
  Hits         1396     1396           
  Misses        474      474           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks cwperks merged commit 89a5121 into 1.3 Aug 21, 2024
12 checks passed
cwperks pushed a commit to cwperks/security-dashboards-plugin that referenced this pull request Aug 22, 2024
…pensearch-project#2096) (opensearch-project#2098)

* Fix a bug where basepath nextUrl is invalid when it should be valid



* Udpate test



---------


(cherry picked from commit b1148fb)

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants