Fix button label #2130
Merged
Fix button label #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
=======================================
Coverage 71.40% 71.40%
=======================================
Files 97 97
Lines 2651 2651
Branches 404 411 +7
=======================================
Hits 1893 1893
Misses 642 642
Partials 116 116 ☔ View full report in Codecov by Sentry. |
cwperks
previously approved these changes
Oct 1, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
reviewed
Oct 1, 2024
cwperks
previously approved these changes
Oct 1, 2024
DarshitChanpura
previously approved these changes
Oct 1, 2024
|
Just wanna share one of the solutions we are thinking in observability dashboards: opensearch-project/dashboards-observability#2187. So basically we added a specific step for compilation. cc @Swiddis |
RyanL1997
previously approved these changes
Oct 1, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
dismissed stale reviews from RyanL1997, DarshitChanpura, and cwperks
via
514877c
Signed-off-by: Derek Ho <dxho@amazon.com>
Thanks, stole the compile step idea from the above PR and now it's working again. Maybe we should cut an issue to OSD core repo to make sure somebody is aware of this increase. It seems to have happened within the last 2 weeks, before that things were consistently under 600, now it is above. |
cwperks
reviewed
Oct 2, 2024
cwperks
approved these changes
Oct 2, 2024
DarshitChanpura
approved these changes
Oct 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Fix button label Signed-off-by: Derek Ho <dxho@amazon.com> * Debug Signed-off-by: Derek Ho <dxho@amazon.com> * look for server running instead of bundles compiled Signed-off-by: Derek Ho <dxho@amazon.com> * increase timeout to 900 seconds Signed-off-by: Derek Ho <dxho@amazon.com> * Actually change timeout to 900 seconds Signed-off-by: Derek Ho <dxho@amazon.com> * Try compile step Signed-off-by: Derek Ho <dxho@amazon.com> * Bash Signed-off-by: Derek Ho <dxho@amazon.com> * Fix messaging + look for start now that compile is different step Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit dc3e5a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Fix button label * Debug * look for server running instead of bundles compiled * increase timeout to 900 seconds * Actually change timeout to 900 seconds * Try compile step * Bash * Fix messaging + look for start now that compile is different step --------- (cherry picked from commit dc3e5a9) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the button label for config.yml documentation on the "Get Started" page
Category
Bug fix
Why these changes are required?
Fix: #2129
What is the old behavior before changes and new behavior after changes?
Used to say "Create config.yml", now it says "Config.yml documentation"
Issues Resolved
Fix: #2129
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.