Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Stephen to emeritus #4797

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Move Stephen to emeritus #4797

merged 2 commits into from
Oct 9, 2024

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Oct 8, 2024

Description

Moves @stephen-crawford to emeritus maintainer

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@cwperks cwperks changed the title Add Stephen to emeritus Move Stephen to emeritus Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.92%. Comparing base (903b7b3) to head (509a31f).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4797      +/-   ##
==========================================
+ Coverage   67.95%   70.92%   +2.97%     
==========================================
  Files         310      310              
  Lines       20927    20938      +11     
  Branches     3322     3326       +4     
==========================================
+ Hits        14220    14851     +631     
+ Misses       4953     4339     -614     
+ Partials     1754     1748       -6     

see 72 files with indirect coverage changes

MAINTAINERS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon voyage

@reta
Copy link
Collaborator

reta commented Oct 9, 2024

Bon voyage

Thanks a mill for your contributions, @stephen-crawford !

willyborankin
willyborankin previously approved these changes Oct 9, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
@cwperks cwperks added backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch labels Oct 9, 2024
@derek-ho derek-ho merged commit 0965d54 into opensearch-project:main Oct 9, 2024
44 checks passed
@derek-ho derek-ho deleted the sc branch October 9, 2024 15:18
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 0965d54)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 0965d54)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants