Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChannelAlreadyClosed error in RateLimitersApiActionTest.testInvalidDeleteScenarios #4812

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix ChannelAlreadyClosed error in RateLimitersApiActionTest.testInvalidDeleteScenarios #4812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/main/java/org/opensearch/security/dlic/rest/api/RateLimitersApiAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,14 @@ private void authFailureConfigApiRequestHandlers(RequestHandler.RequestHandlersB
// Try to remove the listener by name
if (config.dynamic.auth_failure_listeners.getListeners().remove(listenerName) == null) {
notFound(channel, "listener not found");
} else {
saveOrUpdateConfiguration(client, configuration, new OnSucessActionListener<>(channel) {
@Override
public void onResponse(IndexResponse indexResponse) {
ok(channel, authFailureContent(config));
}
});
}
saveOrUpdateConfiguration(client, configuration, new OnSucessActionListener<>(channel) {
@Override
public void onResponse(IndexResponse indexResponse) {
ok(channel, authFailureContent(config));
}
});
}).error((status, toXContent) -> response(channel, status, toXContent)))
.override(PUT, (channel, request, client) -> loadConfiguration(getConfigType(), false, false).valid(configuration -> {
ConfigV7 config = (ConfigV7) configuration.getCEntry(CType.CONFIG.toLCString());
Expand Down
Loading