diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/executor/GetIndexRequestRestListener.java b/legacy/src/main/java/org/opensearch/sql/legacy/executor/GetIndexRequestRestListener.java index ebd9648d5e..1adb0e745e 100644 --- a/legacy/src/main/java/org/opensearch/sql/legacy/executor/GetIndexRequestRestListener.java +++ b/legacy/src/main/java/org/opensearch/sql/legacy/executor/GetIndexRequestRestListener.java @@ -6,16 +6,13 @@ package org.opensearch.sql.legacy.executor; -import com.carrotsearch.hppc.cursors.ObjectObjectCursor; import java.io.IOException; import java.util.List; -import java.util.Map; import org.opensearch.action.admin.indices.get.GetIndexRequest; import org.opensearch.action.admin.indices.get.GetIndexResponse; import org.opensearch.cluster.metadata.AliasMetadata; import org.opensearch.cluster.metadata.MappingMetadata; -import org.opensearch.common.collect.ImmutableOpenMap; import org.opensearch.common.settings.Settings; import org.opensearch.core.xcontent.ToXContent; import org.opensearch.core.xcontent.XContentBuilder; @@ -25,7 +22,6 @@ import org.opensearch.rest.RestStatus; import org.opensearch.rest.action.RestBuilderListener; import org.opensearch.sql.legacy.antlr.semantic.SemanticAnalysisException; -import org.opensearch.sql.legacy.domain.Field; /** * Created by Eliran on 6/10/2015. diff --git a/legacy/src/test/java/org/opensearch/sql/legacy/util/CheckScriptContents.java b/legacy/src/test/java/org/opensearch/sql/legacy/util/CheckScriptContents.java index ff93117f4a..09c3e327eb 100644 --- a/legacy/src/test/java/org/opensearch/sql/legacy/util/CheckScriptContents.java +++ b/legacy/src/test/java/org/opensearch/sql/legacy/util/CheckScriptContents.java @@ -37,10 +37,8 @@ import org.opensearch.cluster.ClusterState; import org.opensearch.cluster.metadata.IndexMetadata; import org.opensearch.cluster.metadata.IndexNameExpressionResolver; -import org.opensearch.cluster.metadata.MappingMetadata; import org.opensearch.cluster.metadata.Metadata; import org.opensearch.cluster.service.ClusterService; -import org.opensearch.common.collect.ImmutableOpenMap; import org.opensearch.common.xcontent.XContentType; import org.opensearch.core.xcontent.DeprecationHandler; import org.opensearch.core.xcontent.NamedXContentRegistry; diff --git a/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClient.java b/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClient.java index 79afd8829b..b6ca5471e5 100644 --- a/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClient.java +++ b/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClient.java @@ -112,11 +112,11 @@ public Map getIndexMaxResultWindows(String... indexExpression) GetSettingsResponse settingsResponse = client.admin().indices().prepareGetSettings(indexExpression).setLocal(true).get(); ImmutableMap.Builder result = ImmutableMap.builder(); - for (ObjectObjectCursor indexToSetting : - settingsResponse.getIndexToSettings()) { - Settings settings = indexToSetting.value; + for (Map.Entry indexToSetting : + settingsResponse.getIndexToSettings().entrySet()) { + Settings settings = indexToSetting.getValue(); result.put( - indexToSetting.key, + indexToSetting.getKey(), settings.getAsInt( IndexSettings.MAX_RESULT_WINDOW_SETTING.getKey(), IndexSettings.MAX_RESULT_WINDOW_SETTING.getDefault(settings))); diff --git a/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchRestClient.java b/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchRestClient.java index 757ea99c1b..c27c4bbc30 100644 --- a/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchRestClient.java +++ b/opensearch/src/main/java/org/opensearch/sql/opensearch/client/OpenSearchRestClient.java @@ -30,7 +30,6 @@ import org.opensearch.client.indices.GetMappingsResponse; import org.opensearch.client.node.NodeClient; import org.opensearch.cluster.metadata.AliasMetadata; -import org.opensearch.common.collect.ImmutableOpenMap; import org.opensearch.common.settings.Settings; import org.opensearch.sql.opensearch.mapping.IndexMapping; import org.opensearch.sql.opensearch.request.OpenSearchRequest; @@ -85,21 +84,21 @@ public Map getIndexMaxResultWindows(String... indexExpression) .indices(indexExpression).includeDefaults(true); try { GetSettingsResponse response = client.indices().getSettings(request, RequestOptions.DEFAULT); - ImmutableOpenMap settings = response.getIndexToSettings(); - ImmutableOpenMap defaultSettings = response.getIndexToDefaultSettings(); + Map settings = response.getIndexToSettings(); + Map defaultSettings = response.getIndexToDefaultSettings(); Map result = new HashMap<>(); - defaultSettings.forEach(entry -> { - Integer maxResultWindow = entry.value.getAsInt("index.max_result_window", null); + defaultSettings.forEach((key, value) -> { + Integer maxResultWindow = value.getAsInt("index.max_result_window", null); if (maxResultWindow != null) { - result.put(entry.key, maxResultWindow); + result.put(key, maxResultWindow); } }); - settings.forEach(entry -> { - Integer maxResultWindow = entry.value.getAsInt("index.max_result_window", null); + settings.forEach((key, value) -> { + Integer maxResultWindow = value.getAsInt("index.max_result_window", null); if (maxResultWindow != null) { - result.put(entry.key, maxResultWindow); + result.put(key, maxResultWindow); } }); diff --git a/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClientTest.java b/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClientTest.java index 6c400ff3ca..71a954bca3 100644 --- a/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClientTest.java +++ b/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchNodeClientTest.java @@ -59,7 +59,6 @@ import org.opensearch.cluster.metadata.AliasMetadata; import org.opensearch.cluster.metadata.IndexMetadata; import org.opensearch.cluster.metadata.MappingMetadata; -import org.opensearch.common.collect.ImmutableOpenMap; import org.opensearch.common.settings.Settings; import org.opensearch.common.unit.TimeValue; import org.opensearch.common.util.concurrent.ThreadContext; @@ -453,10 +452,8 @@ private void mockNodeClientSettings(String indexName, String indexMetadata) GetSettingsResponse mockResponse = mock(GetSettingsResponse.class); when(nodeClient.admin().indices().prepareGetSettings(any()).setLocal(anyBoolean()).get()) .thenReturn(mockResponse); - ImmutableOpenMap metadata = - new ImmutableOpenMap.Builder() - .fPut(indexName, IndexMetadata.fromXContent(createParser(indexMetadata)).getSettings()) - .build(); + Map metadata = Map.of(indexName, + IndexMetadata.fromXContent(createParser(indexMetadata)).getSettings()); when(mockResponse.getIndexToSettings()).thenReturn(metadata); } diff --git a/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchRestClientTest.java b/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchRestClientTest.java index e6b6be117a..b521c6605c 100644 --- a/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchRestClientTest.java +++ b/opensearch/src/test/java/org/opensearch/sql/opensearch/client/OpenSearchRestClientTest.java @@ -54,7 +54,6 @@ import org.opensearch.client.indices.GetMappingsResponse; import org.opensearch.cluster.metadata.IndexMetadata; import org.opensearch.cluster.metadata.MappingMetadata; -import org.opensearch.common.collect.ImmutableOpenMap; import org.opensearch.common.settings.Settings; import org.opensearch.common.unit.TimeValue; import org.opensearch.common.xcontent.XContentType; @@ -240,9 +239,9 @@ void get_index_max_result_windows_settings() throws IOException { .put("index.max_result_window", maxResultWindow) .build(); Settings emptySettings = Settings.builder().build(); - ImmutableOpenMap indexToSettings = + Map indexToSettings = mockSettings(indexName, maxResultWindowSettings); - ImmutableOpenMap indexToDefaultSettings = + Map indexToDefaultSettings = mockSettings(indexName, emptySettings); when(response.getIndexToSettings()).thenReturn(indexToSettings); when(response.getIndexToDefaultSettings()).thenReturn(indexToDefaultSettings); @@ -264,9 +263,9 @@ void get_index_max_result_windows_default_settings() throws IOException { .put("index.max_result_window", maxResultWindow) .build(); Settings emptySettings = Settings.builder().build(); - ImmutableOpenMap indexToSettings = + Map indexToSettings = mockSettings(indexName, emptySettings); - ImmutableOpenMap indexToDefaultSettings = + Map indexToDefaultSettings = mockSettings(indexName, maxResultWindowSettings); when(response.getIndexToSettings()).thenReturn(indexToSettings); when(response.getIndexToDefaultSettings()).thenReturn(indexToDefaultSettings); @@ -451,10 +450,8 @@ private Map mockFieldMappings(String indexName, String return ImmutableMap.of(indexName, IndexMetadata.fromXContent(createParser(mappings)).mapping()); } - private ImmutableOpenMap mockSettings(String indexName, Settings settings) { - ImmutableOpenMap.Builder indexToSettingsBuilder = ImmutableOpenMap.builder(); - indexToSettingsBuilder.put(indexName, settings); - return indexToSettingsBuilder.build(); + private Map mockSettings(String indexName, Settings settings) { + return Map.of(indexName, settings); } private XContentParser createParser(String mappings) throws IOException {