Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux toolkit peerDep #2623

Closed
jschuler opened this issue Jun 27, 2024 · 2 comments
Closed

redux toolkit peerDep #2623

jschuler opened this issue Jun 27, 2024 · 2 comments

Comments

@jschuler
Copy link
Contributor

ui-lib has peerDependency for redux toolkit ^1.9.1
But uhc-portal (OCM) uses ^2.2.2.

Is it necessary for ui-lib to have that peerDep?

➜  uhc-portal git:(master) ✗ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: cloud.openshift.com@0.0.0
npm ERR! Found: @reduxjs/toolkit@2.2.5
npm ERR! node_modules/@reduxjs/toolkit
npm ERR!   @reduxjs/toolkit@"^2.2.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @reduxjs/toolkit@"^1.9.1" from @openshift-assisted/ui-lib@2.32.2
npm ERR! node_modules/@openshift-assisted/ui-lib
npm ERR!   @openshift-assisted/ui-lib@"2.32.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/jschuler/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jschuler/.npm/_logs/2024-06-27T16_52_05_210Z-debug-0.log
@ammont82
Copy link
Contributor

I'm working in a MR to solve problems with dependencies: #2621
@jschuler do you have a branch for uhc-portal to test these changes?

@jschuler
Copy link
Contributor Author

I think this issue is also captured in #2624 so closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants