Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-14787: Event pagination test flakiness #2225

Merged

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov commented Jun 26, 2023

Changed the tests. Let's hope they are more stable now :')

@jgyselov jgyselov requested a review from a team as a code owner June 26, 2023 06:54
@jgyselov jgyselov added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 26, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2023
@jgyselov jgyselov force-pushed the events_pagination_tests_3 branch 2 times, most recently from f115581 to 8667d1e Compare June 26, 2023 08:16
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2023
@jgyselov jgyselov force-pushed the events_pagination_tests_3 branch 2 times, most recently from 9719c80 to c30d172 Compare June 26, 2023 08:43
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2023
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2023
@jgyselov jgyselov force-pushed the events_pagination_tests_3 branch 3 times, most recently from 364f3f8 to 2c0d77a Compare June 26, 2023 09:51
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2023
@jgyselov jgyselov force-pushed the events_pagination_tests_3 branch 2 times, most recently from cef247e to d5e0c41 Compare June 26, 2023 10:34
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2023
@jgyselov jgyselov force-pushed the events_pagination_tests_3 branch 3 times, most recently from 5efd456 to b7a6993 Compare June 26, 2023 11:42
@jgyselov jgyselov changed the title Event pagination test flakiness MGMT-14787: Event pagination test flakiness Jun 26, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 26, 2023

@jgyselov: This pull request references MGMT-14787 which is a valid jira issue.

In response to this:

Changed the tests. Let's hope they are more stable now :')

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jgyselov jgyselov removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 26, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@ammont82 ammont82 added this to the v2.22 milestone Jun 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkilzi jkilzi merged commit 692528f into openshift-assisted:master Jun 27, 2023
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
@jgyselov jgyselov deleted the events_pagination_tests_3 branch October 2, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants