Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-12926: Grouping disks by holders #2269

Merged
merged 6 commits into from
Jul 27, 2023
Merged

MGMT-12926: Grouping disks by holders #2269

merged 6 commits into from
Jul 27, 2023

Conversation

jgyselov
Copy link
Collaborator

https://issues.redhat.com/browse/MGMT-12926

  • Disks with the drive type "LVM" are hidden.
  • The disks are first sorted by name and then by holders (or name again if the disk is a holder itself).
  • Disks with one defined holder are indented. This should result in a visual hierarchy:

image

  • If a disk with holders is selected as the installation disk, we show a warning icon and a popover. The content depends on the holder's drive type (LVM, RAID, multipath).
    image

  • Under the storage table, we show a new alert in case there are limitations for the selected installation disk.
    image

  • In case multiple hosts have installation disk limitations, we show the warnings in a list.
    image

@jgyselov jgyselov added the OCM label Jul 20, 2023
@jgyselov jgyselov added this to the v2.24 milestone Jul 20, 2023
@jgyselov jgyselov requested a review from a team as a code owner July 20, 2023 09:39
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2023 •
edited by openshift-ci bot
Loading

@jgyselov: This pull request references MGMT-12926 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/MGMT-12926

  • Disks with the drive type "LVM" are hidden.
  • The disks are first sorted by name and then by holders (or name again if the disk is a holder itself).
  • Disks with one defined holder are indented. This should result in a visual hierarchy:

image

  • If a disk with holders is selected as the installation disk, we show a warning icon and a popover. The content depends on the holder's drive type (LVM, RAID, multipath).
    image

  • Under the storage table, we show a new alert in case there are limitations for the selected installation disk.
    image

  • In case multiple hosts have installation disk limitations, we show the warnings in a list.
    image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 20, 2023
@jgyselov jgyselov force-pushed the storage_disk_holders branch 3 times, most recently from 6274aa9 to 14bcaf3 Compare July 21, 2023 09:17
jkilzi
jkilzi previously approved these changes Jul 23, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2023
ammont82
ammont82 previously approved these changes Jul 24, 2023
View reviewed changes
@jgyselov jgyselov added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 24, 2023
@jgyselov jgyselov dismissed stale reviews from ammont82 and jkilzi via e1e0644 July 24, 2023 10:02
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@jgyselov jgyselov removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 24, 2023
@jgyselov jgyselov force-pushed the storage_disk_holders branch 3 times, most recently from c619ea2 to 4cef8ca Compare July 25, 2023 07:50
@jgyselov jgyselov added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@jgyselov jgyselov removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@jgyselov jgyselov requested review from jkilzi and ammont82 July 26, 2023 07:16
@jgyselov
Copy link
Collaborator Author

The /views part of the tests will need a refactor. But for the time being, it does the job.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit c5be684 into openshift-assisted:master Jul 27, 2023
8 checks passed
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
@jgyselov @ammont82 @rawagner
MGMT-12926: Grouping disks by holders (openshift-assisted#2269)
243550c 
* Grouping disks by holders

* Tests for grouping disks by holders

* Cleanup selectors and constants

* Extract StoragePage and Alert classes

* Align test classes and structure

---------

Co-authored-by: Montse Ortega <ammont82@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkilzi jkilzi jkilzi approved these changes

@ammont82 ammont82 ammont82 approved these changes

Assignees

@ammont82 ammont82

@jkilzi jkilzi

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v2.24
Development

Successfully merging this pull request may close these issues.
4 participants
@jgyselov @openshift-ci-robot @ammont82 @jkilzi