-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-15374: Unties common-to-ocm dependencies #2279
Conversation
@jkilzi: This pull request references MGMT-15374 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jkilzi: This pull request references MGMT-15374 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Moves fileSize and stringToJson to lib/common/utils.ts in order to break circular dependencies
@jkilzi: This pull request references MGMT-15374 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, jgyselov, jkilzi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Breaks common-to-ocm dependencies * Breaks circular dependencies Moves fileSize and stringToJson to lib/common/utils.ts in order to break circular dependencies
Basically I used this regex:
import (.+) from '.+(?=(cim|ocm)).+';
in order to search for imports referencing thecim
orocm
folder from within thecommon
folder.The search yielded 2 modules:
Once the
common
folder doesn't depend onocm
orcim
, I'll be able to convert the directory into a stand-alone package thatocm
andcim
can use as a dependency. This will later allow for splittingcim
andocm
into different packages.The PR is a bit large mainly because after moving the cross-dependencies to the
common
folder I encountered some circular dependencies related tofileSize
andstringToJSON
. This issue is resolved in the second commit.