Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-15380: Not set userManagedNetworking=true when user select arm64 as cpu architecture #2280

Merged
merged 4 commits into from
Jul 31, 2023
Merged

MGMT-15380: Not set userManagedNetworking=true when user select arm64 as cpu architecture #2280

merged 4 commits into from
Jul 31, 2023

Conversation

ammont82
Copy link
Contributor

Related to https://issues.redhat.com/browse/MGMT-15380

Creating Arm cluster, UI sends in post request UMN=true, although according to https://docs.google.com/spreadsheets/d/1IJugmChJTKMBjdXHojEgfsyE8WT-dGbUpETn8fhuI7g/edit#gid=0
This should only be sent for ARM64 with OCP 4.10

  • With OCP 4.10+ARM64:
    image

  • With OCP 4.13+ARM64:
    image

@ammont82 ammont82 requested a review from a team as a code owner July 27, 2023 12:00
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 27, 2023 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-15380 which is a valid jira issue.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-15380

Creating Arm cluster, UI sends in post request UMN=true, although according to https://docs.google.com/spreadsheets/d/1IJugmChJTKMBjdXHojEgfsyE8WT-dGbUpETn8fhuI7g/edit#gid=0
This should only be sent for ARM64 with OCP 4.10

  • With OCP 4.10+ARM64:
    image

  • With OCP 4.13+ARM64:
    image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 27, 2023
@ammont82 ammont82 changed the title MGMT-15380: Not set userManagedNetworking=true when user select arm64 MGMT-15380: Not set userManagedNetworking=true when user select arm64 as cpu architecture Jul 27, 2023
@ammont82 ammont82 added this to the v2.24 milestone Jul 27, 2023
@ammont82 ammont82 added the OCM label Jul 27, 2023
@ammont82 ammont82 requested a review from jgyselov July 28, 2023 07:07
jgyselov
jgyselov previously approved these changes Jul 28, 2023
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@jkilzi jkilzi requested review from jgyselov and celdrake July 31, 2023 13:21
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkilzi jkilzi merged commit 30a933f into openshift-assisted:master Jul 31, 2023
8 checks passed
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
@ammont82 @jkilzi @rawagner
MGMT-15380: Not set userManagedNetworking=true when user select arm64…
6c27844 
… as cpu architecture (openshift-assisted#2280)

* Not set userManagedNetworking=true when user select arm64

* Removing console.log

* Set UMN = true only when CMN is not supported according to the API

---------

Co-authored-by: Jonathan Kilzi <jkilzi@redhat.com>
@ammont82 ammont82 deleted the MGMT-15380-create-arm64-cluster-with-umn-set-to-false branch December 21, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkilzi jkilzi jkilzi approved these changes

@celdrake celdrake celdrake approved these changes

@jgyselov jgyselov Awaiting requested review from jgyselov

Assignees

@celdrake celdrake

@jkilzi jkilzi

@jgyselov jgyselov

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v2.24
Development

Successfully merging this pull request may close these issues.
5 participants
@ammont82 @openshift-ci-robot @celdrake @jkilzi @jgyselov