Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18567: Solving errors in clusters list #2652

Conversation

ammont82
Copy link
Contributor

Related to https://issues.redhat.com/browse/MGMT-18567

Try to solve the error that happens in Assisted Installer clusters list:
image

@ammont82 ammont82 added the OCM label Aug 12, 2024
@ammont82 ammont82 requested a review from a team as a code owner August 12, 2024 13:06
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2024

@ammont82: This pull request references MGMT-18567 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-18567

Try to solve the error that happens in Assisted Installer clusters list:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 12, 2024
@ammont82 ammont82 force-pushed the MGMT-18567-errors-in-cluster-list-master branch from c659dad to 8f3f804 Compare August 14, 2024 08:15
@ammont82 ammont82 force-pushed the MGMT-18567-errors-in-cluster-list-master branch from 8f3f804 to 425d758 Compare August 14, 2024 08:47
jgyselov
jgyselov previously approved these changes Aug 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@mareklibra
Copy link
Contributor

We should fix this upstream, is there a patch?

I understand it will take long time to get merged there and bubble the release here, so this fix looks good to me.
I suggest to add a link to upstream patch/issue, so we can eventually remove this custom re-implementation in the future.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
Copy link

openshift-ci bot commented Aug 15, 2024

@mareklibra: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgyselov jgyselov added this to the v2.35 milestone Aug 20, 2024
Copy link

openshift-ci bot commented Aug 21, 2024

@jkilzi: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi, mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov merged commit 5a35b21 into openshift-assisted:master Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants