Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Work with OCM-UI router v6 ugprade #2655

Merged
merged 6 commits into from
Sep 17, 2024
Merged

NO-ISSUE: Work with OCM-UI router v6 ugprade #2655

merged 6 commits into from
Sep 17, 2024

Conversation

jgyselov
Copy link
Collaborator

No description provided.

@jgyselov jgyselov requested a review from a team as a code owner August 16, 2024 12:29
@openshift-ci-robot
Copy link

@jgyselov: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 16, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2024
@jgyselov jgyselov mentioned this pull request Aug 19, 2024
Closed
@jschuler
Copy link
Contributor

jschuler commented Aug 20, 2024 •
edited
Loading

Hi @jgyselov would it be possible to pick up this change as well?
it's not completely related so if you prefer can be done separately but it's a very small change :) We are changing "Clusters" to "Cluster List" in OCMUI

Oh! also it should route to /cluster-list because we just changed default routing of / to route to the Overview page, not Cluster list anymore!

https://issues.redhat.com/browse/OCMUI-2199

@jgyselov
Copy link
Collaborator Author

Hi @jgyselov would it be possible to pick up this change as well? it's not completely related so if you prefer can be done separately but it's a very small change :) We are changing "Clusters" to "Cluster List" in OCMUI

Oh! also it should route to /cluster-list because we just changed default routing of / to route to the Overview page, not Cluster list anymore!

https://issues.redhat.com/browse/OCMUI-2199

Hi @jschuler, sure, no problem, I can make this change.

But are you sure about the capital L in "Cluster List"? I would have expected sentence case there.

rawagner
rawagner previously approved these changes Aug 22, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
jkilzi
jkilzi previously approved these changes Aug 22, 2024
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 22, 2024

New changes are detected. LGTM label has been removed.

@jschuler
Copy link
Contributor

@jgyselov good question about the sentence casing, I would say let's move forward for now but I'll circle back with some folks and we can change if needed later on

@jgyselov jgyselov dismissed stale reviews from jkilzi and rawagner via 1857cfa September 17, 2024 09:55
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov force-pushed the react-router-dom-tweaks branch 2 times, most recently from 2959b65 to 13c4c54 Compare September 17, 2024 09:56
@ammont82 ammont82 merged commit 957551d into openshift-assisted:master Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschuler jschuler jschuler left review comments

@jkilzi jkilzi jkilzi left review comments

@rawagner rawagner rawagner left review comments

Assignees

@rawagner rawagner

@jkilzi jkilzi

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgyselov @openshift-ci-robot @jschuler @rawagner @jkilzi @ammont82