Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ART-10563 Create build-microshift-bootc job #4270

Merged
merged 8 commits into from
Nov 12, 2024
Merged

ART-10563 Create build-microshift-bootc job #4270

merged 8 commits into from
Nov 12, 2024

Conversation

thegreyd
Copy link
Contributor

@thegreyd thegreyd commented Oct 16, 2024 •
edited
Loading

@thegreyd thegreyd changed the title ART-10563 Pass konflux build cred to build-microshift WIP ART-10563 Pass konflux build cred to build-microshift Oct 16, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@thegreyd thegreyd changed the title WIP ART-10563 Pass konflux build cred to build-microshift ART-10563 Pass konflux build cred to build-microshift Oct 16, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@thegreyd thegreyd mentioned this pull request Oct 16, 2024
Merged
@thegreyd thegreyd added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 16, 2024
@thegreyd thegreyd force-pushed the pass_konflux_build_cred_microshift branch from 9bd9fac to a17601d Compare November 5, 2024 22:07
@thegreyd thegreyd changed the title ART-10563 Pass konflux build cred to build-microshift ART-10563 Create build-microshift-bootc job Nov 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

@thegreyd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d31f9e9 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

joepvd
joepvd approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold to allow for coordinated deploy.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@thegreyd thegreyd merged commit 243f041 into openshift-eng:master Nov 12, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepvd joepvd joepvd approved these changes

Assignees

@joepvd joepvd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thegreyd @joepvd