ART-10563 Build bootc image as part of build-microshift-bootc job #1054
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
thegreyd
added
the
tide/merge-method-squash
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
thegreyd
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
add --no-advisory-prep flag Fixes tweak rebase version Always lock upstream to head Lock build command as well respect dry-run include microshift as one of the stream assemblies find if build already exists fetch build Bind to table Build plashets check if rebuild is needed fix fix logger Fix Fix Fix stream add microshift nvr check fix rebuild needed condition Spinoff into its own pipeline Fix import Fix invoke Remove dead var Fix force-bootc Fix microshift fetch load wip revert unrelated changes fix lint fetch true latest end time fix revert unrelated changes Sync to mirror fix imports move func to util move func to pyartcd.util stringify path temp build all arches add konflux namespace log better
|
@thegreyd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
thegreyd
changed the title
openshift-ci
bot
added
lgtm
ashwindasr
removed
approved
|
Accidental approval, was meant for #1113 Removed labels |
| help="Force plashet sync even if it is not needed") | ||
| @pass_runtime | ||
| @click_coroutine | ||
| async def build_microshift_bootc(runtime: Runtime, data_path: str, group: str, assembly: str, force: bool, |
There was a problem hiding this comment.
Looks like there are not really steps that run in parallel. Would it make sense to get rid of the async keyword here, and treat the code as imperative? Having the impression that this is a needless complication.
There was a problem hiding this comment.
This is going to be difficult.. a lot of our utils / standard methods have moved to async by default like exectools. And the non-async methods have drifted or lag in functionality that the async methods now have.
| build_cmd.append("--dry-run") | ||
| await exectools.cmd_assert_async(build_cmd, env=self._doozer_env_vars) | ||
|
|
||
| # sleep a little bit to account for time drift between systems |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr, joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
New changes are detected. LGTM label has been removed. |
https://issues.redhat.com/browse/ART-10563
Should go after openshift-eng/aos-cd-jobs#4270
Live run: https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/hack/job/sidsharm-aos-cd-jobs/job/build%252Fbuild-microshift/37/
Summary of changes:
bootc-pullspec.txtto mirror (https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/4.18.0-ec.1/el9/bootc-pullspec.txt) for each arch the image built for.