Add redhat prefix check

Ported from:
https://github.com/openshift-helm-charts/development/blob/919146bc199e6366c40cf10d533d4669bd3def70/scripts/src/checkprcontent/checkpr.py#L211-L222

Signed-off-by: Matthias Goerens <mgoerens@redhat.com>

scripts/src/precheck/submission.py

@@ -51,6 +51,10 @@ class ReleaseTagError(SubmissionError):
     pass
 
 
+class ChartError(Exception):
+    pass
+
+
 @dataclass
 class Chart:
     """Represents a Helm Chart
@@ -80,6 +84,17 @@ def register_chart_info(self, category, organization, name, version):
             )
             raise VersionError(msg)
 
+        # Red Hat charts must carry the Red Hat prefix.
+        if organization == "redhat":
+            if not name.startswith("redhat-"):
+                msg = f"[ERROR] Charts provided by Red Hat must have their name begin with the redhat- prefix. I.e. redhat-{name}"
+                raise ChartError(msg)
+
+        # Non Red Hat charts must not carry the Red Hat prefix.
+        if organization != "redhat" and name.startswith("redhat-"):
+            msg = f"[ERROR] The redhat- prefix is reserved for charts provided by Red Hat. Your chart: {name}"
+            raise ChartError(msg)
+
         self.category = category
         self.organization = organization
         self.name = name

scripts/src/precheck/submission_test.py

@@ -221,6 +221,22 @@ class SubmissionInitScenario:
         ],
         excepted_exception=pytest.raises(submission.VersionError),
     ),
+    # Invalid PR references a Chart from redhat without the "redhat-" prefix
+    SubmissionInitScenario(
+        api_url="https://api.github.com/repos/openshift-helm-charts/charts/pulls/103",
+        modified_files=[
+            f"charts/{expected_category}/redhat/{expected_name}/{expected_version}/report.yaml"
+        ],
+        excepted_exception=pytest.raises(submission.ChartError),
+    ),
+    # Invalid PR references a Chart with the "redhat-" prefix from another organization
+    SubmissionInitScenario(
+        api_url="https://api.github.com/repos/openshift-helm-charts/charts/pulls/103",
+        modified_files=[
+            f"charts/{expected_category}/{expected_organization}/redhat-{expected_name}/{expected_version}/report.yaml"
+        ],
+        excepted_exception=pytest.raises(submission.ChartError),
+    ),
 ]