-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create action to disable specific workflows based on repo config #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komish
changed the title
Create action to disable specific worfklows based on repo config
Create action to disable specific workflows based on repo config
Aug 9, 2023
Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
komish
force-pushed
the
add-cert-disconnect
branch
from
August 9, 2023 15:59
79c1cfe
to
694a320
Compare
This was referenced Aug 9, 2023
jsm84
approved these changes
Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for some replumbing that's will come in the near future, we need the ability to dynamically disconnect certification while also being able to re-run workflows so that we can retrigger them once we've finished our work.
This PR adds an action that fails if the input provided is not explicitly set to
true
. We feed it a contextual variable, in our case, theCERTIFICATION_ENABLED
variable set at the repository, org, or environment level within the GitHub repo settings.This isn't currently configured to block. For this PoC, I've also added a test workflow that can be manually called by developers to see if the workflow would be blocked.
In a future iteration, I'll likely look to add this to the Certification workflows for the reason described above.
The requisite environment variable
CERTIFICATION_ENABLED
has been set on this repo, stage, charts, and sandbox.