-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure more locations to use the submission regex matchers #277
Merged
komish
merged 1 commit into
openshift-helm-charts:main
from
komish:more-centralized-regex-opportunities
Oct 18, 2023
Merged
Configure more locations to use the submission regex matchers #277
komish
merged 1 commit into
openshift-helm-charts:main
from
komish:more-centralized-regex-opportunities
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2023
komish
force-pushed
the
more-centralized-regex-opportunities
branch
from
October 17, 2023 19:34
65e81f9
to
4073946
Compare
This was referenced Oct 17, 2023
This was referenced Oct 18, 2023
OchiengEd
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
komish
dismissed
mgoerens’s stale review
October 18, 2023 16:00
All review concerns have been addressed, and an approval has been granted after changes were made.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent PR to update our use of submission path regex missed a couple of locations where this was being used, so this PR should address those locations.