Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure more locations to use the submission regex matchers #277

Merged

Conversation

komish
Copy link
Contributor

@komish komish commented Oct 17, 2023

The most recent PR to update our use of submission path regex missed a couple of locations where this was being used, so this PR should address those locations.

This was referenced Oct 17, 2023
@komish komish force-pushed the more-centralized-regex-opportunities branch from 65e81f9 to 4073946 Compare October 17, 2023 19:34
This was referenced Oct 18, 2023
Copy link
Contributor

@OchiengEd OchiengEd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish dismissed mgoerens’s stale review October 18, 2023 16:00

All review concerns have been addressed, and an approval has been granted after changes were made.

@komish komish merged commit 467cbc3 into openshift-helm-charts:main Oct 18, 2023
6 checks passed
@komish komish deleted the more-centralized-regex-opportunities branch October 18, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants