Make the PR comment accessible to the metrics step #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 3, 2023
This was referenced Nov 3, 2023
mgoerens
reviewed
Nov 3, 2023
.github/workflows/build.yml
Outdated
| id: encode_pr_comment | ||
| if: ${{ always() && needs.setup.outputs.run_build == 'true' }} | ||
| run: | | ||
| commentBase64=$(base64 --wrap=0 ./pr/comment) |
There was a problem hiding this comment.
Use ${{ steps.pr_comment.outputs.message-file }} instead of hard-coded ./pr/comment
Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
This was referenced Nov 3, 2023
mgoerens
approved these changes
Nov 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, Metrics reporting is failing because the PR comment it needs is no longer available in the job where it runs.
https://github.com/openshift-helm-charts/charts/actions/runs/6709583883/job/18233057391#step:11:53
I believe that the metrics step can probably be extracted out into its own execution such that it doesn't cause the release step to fail, but until that gets prioritizes, this PR pulls the PR comment contents from the
chart-verifiertask and into thereleasetask by encoding it in a step of the former job, and then writing it back to the expected location in a step of the latter job.Definitely a temporary measure, but it's a quick way to get the release tasks to start passing. At the moment, I would expect them all to fail, even though all the actual releasing activity (e.g. pushing charts, public keys, indexing) succeeded.
Once this merges, I'll probably cut a release to get this into the production pipeline, even though the content is small.