Initialize the Submission data structure #332
Merged
+838
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2024
This was referenced Mar 7, 2024
This was referenced Mar 7, 2024
This was referenced Mar 22, 2024
jsm84
added a commit
to jsm84/openshift-helm-charts-dev
that referenced
this pull request
Jun 3, 2024
Summary: * Standardize action runner versions across workflows by @komish in openshift-helm-charts#339 * Correctly determine the OWNERS file change type by @komish in openshift-helm-charts#340 * Initialize the Submission data structure by @mgoerens in openshift-helm-charts#332 * Allow token access to redhat OWNERS file metadata check automation by @komish in openshift-helm-charts#338 * Remove unused function in 'signed_chart.py' by @mgoerens in openshift-helm-charts#322 * Ping maintainers if the release job fails by @mgoerens in openshift-helm-charts#343 * Rework owners_file.py and add custom exception by @mgoerens in openshift-helm-charts#321 * Add debug information when tests fail to create PR by @mgoerens in openshift-helm-charts#346 * Fix empty PR number in tests logs by @mgoerens in openshift-helm-charts#348 * New chart fixture with plus sign in version by @jsm84 in openshift-helm-charts#349 * Rename crysostat fixture & rm whitespace in provider name by @jsm84 in openshift-helm-charts#351 * Added new test scenario plus-in-version to HC-17 by @jsm84 in openshift-helm-charts#350 * Cleanup unused report fixtures for HC-16 by @jsm84 in charts/development/pull/351 * Added new test scenario plus-in-version to HC-17 by @jsm84 in openshift-helm-charts#350 * Cleanup unused report fixtures for HC-16 by @jsm84 in openshift-helm-charts#352 * Inform caller if web_catatog_only key is missing by @mgoerens in openshift-helm-charts#345 * Add check for web_catalog_only to Submission by @mgoerens in openshift-helm-charts#344 openshift-helm-charts#352 * Inform caller if web_catatog_only key is missing by @mgoerens in openshift-helm-charts#345 * Add check for web_catalog_only to Submission by @mgoerens in openshift-helm-charts#344 **Full Changelog**: openshift-helm-charts/development@1.7.0...1.7.1 Signed-off-by: Josh Manning <19478595+jsm84@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards solving #296. The code added by this commit is currently not put in use in the certification pipeline and is a partial duplicate of the "checkprcontent" package.
The Submission data structure can collect and run early validation checks on all information concerning a user's submission (i.e. a GitHub Pull Request). In its current state, given an api_url (link to a given PR), it can collect the list of modified files, and extract the category, organization, chart's name and version, as well as running basic checks, such as SemVer compatibility of the provided version.
Eventually, this data structure is meant to encapsulate more information concerning the user's submission, and be dumped to a json file (using JSONEncode / JSONDecoder, more on that in a later PR) to be passed around the certification pipeline jobs as an artifact. This early (and incomplete) version is intended to trigger discussion around the design choices and general direction taken to solve #296.