Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.15] Set the name value for metrics tags to the correct top-level resource #1284

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[release-v1.15] Set the name value for metrics tags to the correct top-level resource #1284

merged 1 commit into from
Sep 26, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 25, 2024 •
edited
Loading

Previous to v2, we were setting name to the Broker or Channel name of the resource.

Cherry-pick of knative-extensions#4120

@pierDipi
Set the name value for metrics tags to the correct top-level resource
dc4f9c4 
Previously to v2, we were setting `name` to the Broker or Channel
name of the resource.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi changed the title Set the name value for metrics tags to the correct top-level resource [release-v1.15] Set the name value for metrics tags to the correct top-level resource Sep 25, 2024
@matzew
Copy link
Member

matzew commented Sep 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2dc8b06 and 2 for PR HEAD dc4f9c4 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2dc8b06 and 2 for PR HEAD dc4f9c4 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2dc8b06 and 2 for PR HEAD dc4f9c4 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 26, 2024

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-reconciler-keda-aws-416 dc4f9c4 link true /test 416-test-reconciler-keda-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi pierDipi merged commit 4ed8dce into openshift-knative:release-v1.15 Sep 26, 2024
27 of 51 checks passed
@pierDipi pierDipi deleted the cp-16393a7ccafac2e2132346ac6de73fe87c3c992f-v1.15 branch September 26, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr Awaiting requested review from creydr

@matzew matzew Awaiting requested review from matzew

Assignees

@matzew matzew

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @matzew @openshift-ci-robot