Skip to content

Commit

Permalink
Do not run TestTLSCertificateRotation in parallel with other tests (#777
Browse files Browse the repository at this point in the history
)

This test deletes the serving-tests/serving-certs during the test run.
This might break the other test TestSystemInternalTLS because it waits
for certain log lines to appear in the service pods. Deleting the
serving-certs secret causes the application pods to be deleted so that
the new cert can be mounted. And waiting for given log lines then fails
because the pod no longer exists:
system_internal_tls_test.go:110: TLS not used on requests to
queue-proxy: pods
"system-internal-tls-wgvxqtyx-00001-deployment-6fdc4c8c7d-4ll8q" not
found

Co-authored-by: Martin Gencur <mgencur@redhat.com>
  • Loading branch information
openshift-cherrypick-robot and mgencur authored Jul 29, 2024
1 parent f3c47ec commit e8b9db3
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/e2e/systeminternaltls/system_internal_tls_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ func TestTLSCertificateRotation(t *testing.T) {
t.Skip("Skip this test for non-kourier/contour ingress.")
}

t.Parallel()

clients := test.Setup(t)

names := test.ResourceNames{
Expand Down

0 comments on commit e8b9db3

Please sign in to comment.