[RELEASE-1.14] add startup probe support to Knative Service #758
Conversation
* Add startup probe to CRDs * Allow startup probes in Knative Services * Increase ProgressDeadlineSeconds when startup probe is present * Remove ProgressDeadlineSeconds increase when startup probe is present (cherry picked from commit ac7f585)
|
/override "lint" |
|
@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Lint" |
|
@ReToCode: Overrode contexts on behalf of ReToCode: Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm /hold for the tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@skonto: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/unhold tests passed, lint errors are not relevant for this PR (but we probably should fix those separately). |
openshift-merge-bot
bot
merged commit 6120450
into
openshift-knative:release-v1.14
What this PR does / why we need it:
Which issue(s) this PR fixes:
JIRA: https://issues.redhat.com/browse/SRVKS-1229
Does this PR needs for other branches:
No
Does this PR (patch) needs to update/drop in the future?:
No
/assign @skonto