-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPQE-20708 : clean registry when disk util over 50 percent #82
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zniu1011 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @zniu1011. Thanks for your PR. I'm waiting for a openshift-qe member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4b21efe
to
4a8e4ad
Compare
sed -i -e '/readonly/{n;s/enabled:.*/enabled: true/;}' /opt/registry-"${port}"/config.yaml | ||
systemctl restart registry@"${port}".service | ||
wait_for_container_running registry-"${port}" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see you're removing the readonly. Is the garbage-collect command concurrent-safe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think not... Sorry, I mistook it to be "delete: enabled". We didn't have 'readonly' keyword in config.yaml file, is it really working? Let me add it to gen_registry_file.sh.
4a8e4ad
to
789b38c
Compare
789b38c
to
c5240e8
Compare
Hi @aleskandro , some updates: |
1, Manifest unknown error:
We can find this manifest tag in "repositories" directory, but can't find the data in "blobs", it is probably caused by the data out of sync between the "repositories" and "blobs" when running 'garbage-collect"?
2, When disk util is high, there is more possibility the mirroring fail, so change disk util threshold from 85% to a more suitable value to do "podman garbage-collect".
3, In the latest running, singe arch disconnected case is stable, but multi payload often fail in mirroring with the following error, it may need more investigating why multi payload is more likely to fail.
error: unable to copy layer sha256:93c1c9e1c13bc42cd8e6daee9ff386956ba044fda1d54e36602cae674a8490ef to file://openshift-pipelines/pipelines-nop-rhel8: stream error: stream ID 145; INTERNAL_ERROR; received from peer