AWS with --cli-input-json shows invalid

[owenmather]

The extra comma in the generated --dry-run 07-block-public-access-to-oidc-bucket.json file prevents aws cli from processing using --cli-input-json

ccoctl aws create-identity-provider --name testcluster --public-key-file /home/ec2-user/sts/serviceaccount-signer.public --region eu-west-1 --dry-run --create-private-s3-bucket

aws s3api put-public-access-block --cli-input-json file://./07-block-public-access-to-oidc-bucket.json

Error parsing parameter 'cli-input-json': Invalid JSON received.

cat 07-block-public-access-to-oidc-bucket.json
{
        "Bucket": "testcluster-oidc",
        "PublicAccessBlockConfiguration": {
        "BlockPublicAcls": true,
        "IgnorePublicAcls": true,
        "BlockPublicPolicy": true,
        "RestrictPublicBuckets": true
    }, #<-- invalid JSON 
}

cat 07-block-public-access-to-oidc-bucket.json  | jq
jq: parse error: Expected another key-value pair at line 9, column 1

Works as expected with this comma removed.

cloud-credential-operator/pkg/cmd/provisioning/aws/create_identity_provider.go

Line 59 in d668c18

},

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale