Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Fix JSON for 07-block-public-access-to-oidc-bucket.json #762

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

owenmather
Copy link
Contributor

Proposed fix for #761

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2024
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

Hi @owenmather. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom September 24, 2024 15:49
@dlom
Copy link
Contributor

dlom commented Oct 2, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@dlom
Copy link
Contributor

dlom commented Oct 2, 2024

/label ok-to-test

Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

@dlom: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, owenmather

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@dlom
Copy link
Contributor

dlom commented Oct 2, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.24%. Comparing base (d668c18) to head (59517be).
Report is 27 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #762    +/-   ##
========================================
  Coverage   47.24%   47.24%            
========================================
  Files          96       97     +1     
  Lines       11725    12434   +709     
========================================
+ Hits         5539     5875   +336     
- Misses       5573     5919   +346     
- Partials      613      640    +27     
Files with missing lines Coverage Δ
...g/cmd/provisioning/aws/create_identity_provider.go 65.32% <ø> (ø)

... and 15 files with indirect coverage changes

@dlom
Copy link
Contributor

dlom commented Oct 9, 2024

/retest

@dlom
Copy link
Contributor

dlom commented Oct 14, 2024

/retitle NOJIRA: Fix JSON for 07-block-public-access-to-oidc-bucket.json

@openshift-ci openshift-ci bot changed the title Fix JSON for 07-block-public-access-to-oidc-bucket.json https://github.com/openshift/cloud-credential-operator/issues/761 NOJIRA: Fix JSON for 07-block-public-access-to-oidc-bucket.json Oct 14, 2024
@dlom
Copy link
Contributor

dlom commented Oct 14, 2024

/override jira/valid-reference

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@dlom: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • jira/valid-reference

Only the following failed contexts/checkruns were expected:

  • ci/prow/coverage
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-qe
  • ci/prow/e2e-hypershift
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-cloud-credential-operator-master-coverage
  • pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cloud-credential-operator-master-e2e-aws-qe
  • pull-ci-openshift-cloud-credential-operator-master-e2e-hypershift
  • pull-ci-openshift-cloud-credential-operator-master-e2e-upgrade
  • pull-ci-openshift-cloud-credential-operator-master-images
  • pull-ci-openshift-cloud-credential-operator-master-security
  • pull-ci-openshift-cloud-credential-operator-master-unit
  • pull-ci-openshift-cloud-credential-operator-master-verify
  • pull-ci-openshift-cloud-credential-operator-master-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override jira/valid-reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dlom
Copy link
Contributor

dlom commented Oct 14, 2024

/label jira/valid-reference

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@dlom: The label(s) /label jira/valid-reference cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label jira/valid-reference

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dlom
Copy link
Contributor

dlom commented Oct 14, 2024

/label jira/valid-bug

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@dlom: Can not set label jira/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to this:

/label jira/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstuever jstuever changed the title NOJIRA: Fix JSON for 07-block-public-access-to-oidc-bucket.json NO-JIRA: Fix JSON for 07-block-public-access-to-oidc-bucket.json Dec 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2024
@openshift-ci-robot
Copy link
Contributor

@owenmather: This pull request explicitly references no jira issue.

In response to this:

Proposed fix for #761

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@owenmather: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 320c29a into openshift:master Dec 5, 2024
11 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator
This PR has been included in build ose-cloud-credential-operator-container-v4.19.0-202412060336.p0.g320c29a.assembly.stream.el9.
All builds following this will include this PR.

@owenmather owenmather deleted the patch-1 branch January 15, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants