Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building hypershift: version output always contains "unknown" #3866

Closed
johanneskastl opened this issue Apr 12, 2024 · 8 comments
Closed

Building hypershift: version output always contains "unknown" #3866

johanneskastl opened this issue Apr 12, 2024 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@johanneskastl
Copy link

johanneskastl commented Apr 12, 2024

I am trying to package hypershift for openSUSE, but although the executable and the completion files seem to be fine (have not tested actual functionality), I cannot get it to display the version properly.

$ hypershift version
openshift/hypershift: <unknown>. Latest supported OCP: 4.16.0

Seems like the information should be coming from the buildinfo, not sure if that is just not active in my builds or just being removed for some reason.

Any ideas (other than patching pkg/version/version.go to hardcode the version?

The build call looks like this:

CGO_ENABLED=1 go build \                                                                                                                                                                                          
   -mod=vendor \                                                                                                                                                                                                  
   -buildmode=pie \                                                                                                                                                                                               
   -gcflags=all='-N -l' \                                                                                                                                                                                         
   -o bin/%{name} main.go
@johanneskastl
Copy link
Author

No ideas, anyone?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2024
@johanneskastl
Copy link
Author

No ideas, anyone?

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2024
@johanneskastl
Copy link
Author

No ideas, anyone?

Ping?

@zanetworker
Copy link

zanetworker commented Oct 1, 2024

@johanneskastl HyperShift is a formfactor of Openshift. Works best with RHCOS nodes :)

Or are you asking for a developer setup?

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Nov 1, 2024
Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants