Update to 3.0 #227

machine424 · 2024-09-25T10:36:59Z

to do:

keep our new gitignore (synbot)
update synbot commands
remove remote-write-receiver feature flag setting in CMO
auto-gomemlimit and autogomaxprocs? (SNO)
fallback_scrape_protocol
run some extra palyload tests

To reviewer:
too many commits, please give more attention to the ones I added on top

openshift-ci · 2024-09-25T10:37:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [machine424]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ules/go.uber.org/automaxprocs-1.6.0 Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0

* textparse: Refactored benchmark. Signed-off-by: bwplotka <bwplotka@gmail.com> * Kill sinks, tested, nothing is inlined. Signed-off-by: bwplotka <bwplotka@gmail.com> * Addressed comments. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>

…rlapping-compaction-flag Add missing flag storage.tsdb.allow-overlapping-compaction

# Conflicts: # scrape/scrape.go

…e name See Parser.Type() function. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

…ules/google.golang.org/grpc-1.67.1 Bump google.golang.org/grpc from 1.66.0 to 1.67.1

…ules/golang.org/x/tools-0.25.0 Bump golang.org/x/tools from 0.24.0 to 0.25.0

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.25.0 to 0.26.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.25.0...v0.26.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ules/golang.org/x/tools-0.26.0 build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0

…ules/github.com/gophercloud/gophercloud-1.14.1 Bump github.com/gophercloud/gophercloud from 1.14.0 to 1.14.1

… Units. (prometheus#15095) Signed-off-by: bwplotka <bwplotka@gmail.com>

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

Signed-off-by: Julien <roidelapluie@o11y.eu>

This unifies the documentation of float literals and time durations and updates all references to the old definitions. Signed-off-by: beorn7 <beorn@grafana.com>

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

Extracted HTTP client options (e.g., authentication, proxy settings, TLS configuration, and custom headers) into a dedicated section for improved clarity and organization. This will centralize all HTTP-related options from prometheus/common in one place within the documentation. The remaining HTTP-related settings in sections (e.g. Service Discovery) will be moved in a follow-up PR to further unify the documentation structure. Signed-off-by: Julien <roidelapluie@o11y.eu>

Because we are reimplementing the `IndexReader` to fetch in-order and out-of-order chunks together, we must reproduce the behaviour of `Head.indexRange()`, which floors the minimum time queried at `head.MinTime()`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

Signed-off-by: Julien <roidelapluie@o11y.eu>

…heus#15327 (comment)

machine424 · 2024-12-19T06:59:09Z

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/prometheus-operator#321

machine424 · 2024-12-20T10:00:58Z

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/prometheus-operator#321
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/prometheus-operator#321

machine424 · 2024-12-20T14:54:37Z

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/prometheus-operator#321 openshift/thanos#154
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/prometheus-operator#321 openshift/thanos#154
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/prometheus-operator#321 openshift/thanos#154

machine424 · 2024-12-23T10:28:42Z

/retest-required

machine424 · 2024-12-23T14:31:50Z

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2544
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2544
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2544

machine424 · 2025-01-06T11:19:14Z

/retest-required

machine424 · 2025-01-06T14:15:06Z

/retest-required

machine424 · 2025-01-08T20:37:41Z

scrape/metrics.go

+	sm.targetInvalidContentType = prometheus.NewCounter(
+		prometheus.CounterOpts{
+			Name: "prometheus_target_scrape_pool_invalid_content_type_total",
+			Help: "Total number of times scrape pools could not determine the valid content type of a scrape target.",


Suggested change

Help: "Total number of times scrape pools could not determine the valid content type of a scrape target.",

Help: "Total number of times scrape pools could not determine a valid content type of a scrape target.",

machine424 · 2025-01-08T20:38:29Z

/retest-required

machine424 · 2025-01-08T21:19:20Z

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2554

machine424 · 2025-01-09T11:37:37Z

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2554

…crape protocols breaking change See https://prometheus.io/docs/prometheus/latest/migration/#scrape-protocols

…"quantile" and "le" normalization breaking change See https://prometheus.io/docs/prometheus/latest/migration/#le-and-quantile-label-values

machine424 · 2025-01-09T17:20:07Z

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2554

openshift-ci · 2025-01-09T20:08:59Z

@machine424: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-upgrade	`3dbee39`	link	true	`/test e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024

openshift-ci bot requested review from danielmellado and jan--f September 25, 2024 10:37

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024

roidelapluie and others added 25 commits October 7, 2024 10:50

Merge pull request prometheus#15042 from prometheus/dependabot/go_mod…

989db7b

…ules/go.uber.org/automaxprocs-1.6.0 Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0

Merge pull request prometheus#15113 from yeya24/add-missing-allow-ove…

9d8f93e

…rlapping-compaction-flag Add missing flag storage.tsdb.allow-overlapping-compaction

Merge branch 'main' into nhcb-scrape-impl

ed2e7dc

# Conflicts: # scrape/scrape.go

Rename bType to bName as Type returns the binary name and not the typ…

9c4816d

…e name See Parser.Type() function. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

Merge pull request prometheus#15039 from prometheus/dependabot/go_mod…

b3f6019

…ules/google.golang.org/grpc-1.67.1 Bump google.golang.org/grpc from 1.66.0 to 1.67.1

Merge pull request prometheus#15043 from prometheus/dependabot/go_mod…

a42e847

…ules/golang.org/x/tools-0.25.0 Bump golang.org/x/tools from 0.24.0 to 0.25.0

Merge pull request prometheus#15117 from prometheus/dependabot/go_mod…

1df86df

…ules/golang.org/x/tools-0.26.0 build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0

Merge pull request prometheus#15038 from prometheus/dependabot/go_mod…

2b4ca98

…ules/github.com/gophercloud/gophercloud-1.14.1 Bump github.com/gophercloud/gophercloud from 1.14.0 to 1.14.1

textparse: Refactored main testing utils for reusability; fixed proto…

f6e110d

… Units. (prometheus#15095) Signed-off-by: bwplotka <bwplotka@gmail.com>

Add unit test nhcbparse_test.go

e1a7008

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

Merge branch 'main' into nhcb-scrape-impl

e0444d9

Document the notifications API

db730fc

Signed-off-by: Julien <roidelapluie@o11y.eu>

docs: Declare "float literals are time durations" as stable

08d4b03

This unifies the documentation of float literals and time durations and updates all references to the old definitions. Signed-off-by: beorn7 <beorn@grafana.com>

Make nhcb unit test pass with many exceptions marked as TODOs

2a3aa50

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

Remove http options from remote read/write

e7206c2

Signed-off-by: Julien <roidelapluie@o11y.eu>

Remove HTTP options from alerting

6acf2dc

Signed-off-by: Julien <roidelapluie@o11y.eu>

Remove HTTP options from vultr

675349c

Signed-off-by: Julien <roidelapluie@o11y.eu>

Remove http options from uyuni

aef84c0

Signed-off-by: Julien <roidelapluie@o11y.eu>

Remove http options from Eureka and Scaleway

1dd45fd

Signed-off-by: Julien <roidelapluie@o11y.eu>

Remove HTTP client doc from nomad and marathon

530c3fc

Signed-off-by: Julien <roidelapluie@o11y.eu>

Remove http client docs from linode and lightsail

04b1201

Signed-off-by: Julien <roidelapluie@o11y.eu>

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024

chore: go mod vendor

de12d5b

machine424 force-pushed the test-3.0 branch from 45bc6bc to c5faf75 Compare December 18, 2024 11:23

machine424 added 3 commits December 18, 2024 12:54

chore: adjust .gitignore to adapt with the new UI

1303b9a

chore: generate new UI assets

5865caa

chore: update rh-manifest.txt

6e5886a

machine424 force-pushed the test-3.0 branch from c5faf75 to 6e5886a Compare December 18, 2024 11:55

chore: sync Dockerfile.ocp, see prometheus@ceb844a

f2348ca

machine424 changed the title ~~Test 3.0~~ Update to 3.0 Dec 18, 2024

chore: adjust promql/ as a commit was missing from v3.0.1, see promet…

a377671

…heus#15327 (comment)

machine424 mentioned this pull request Dec 19, 2024

OCPBUGS-18656: Bump openshift/prometheus-operator to v0.79.2 openshift/prometheus-operator#321

Merged

machine424 mentioned this pull request Jan 6, 2025

chore(manifests): disable --auto-gomemlimit for Prometheus on SNO unt… openshift/cluster-monitoring-operator#2549

Draft

2 tasks

machine424 commented Jan 8, 2025

View reviewed changes

machine424 force-pushed the test-3.0 branch from 5522f86 to c119477 Compare January 9, 2025 10:30

machine424 force-pushed the test-3.0 branch from c119477 to f26e542 Compare January 9, 2025 16:47

machine424 added 2 commits January 9, 2025 17:55

feat(scrape): offer assistance for a smooth Prom3 upgrade after the s…

d3016e4

…crape protocols breaking change See https://prometheus.io/docs/prometheus/latest/migration/#scrape-protocols

feat(parser): offer assistance for a smooth Prom 3 upgrade after the …

3dbee39

…"quantile" and "le" normalization breaking change See https://prometheus.io/docs/prometheus/latest/migration/#le-and-quantile-label-values

machine424 force-pushed the test-3.0 branch from f26e542 to 3dbee39 Compare January 9, 2025 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to 3.0 #227

Update to 3.0 #227

machine424 commented Sep 25, 2024 •

edited

Loading

openshift-ci bot commented Sep 25, 2024

machine424 commented Dec 19, 2024

machine424 commented Dec 20, 2024

machine424 commented Dec 20, 2024

machine424 commented Dec 23, 2024

machine424 commented Dec 23, 2024

machine424 commented Jan 6, 2025

machine424 commented Jan 6, 2025

machine424 Jan 8, 2025

machine424 commented Jan 8, 2025

machine424 commented Jan 8, 2025

machine424 commented Jan 9, 2025

machine424 commented Jan 9, 2025

openshift-ci bot commented Jan 9, 2025

	Help: "Total number of times scrape pools could not determine the valid content type of a scrape target.",
	Help: "Total number of times scrape pools could not determine a valid content type of a scrape target.",

Update to 3.0 #227

Are you sure you want to change the base?

Update to 3.0 #227

Conversation

machine424 commented Sep 25, 2024 • edited Loading

openshift-ci bot commented Sep 25, 2024

machine424 commented Dec 19, 2024

machine424 commented Dec 20, 2024

machine424 commented Dec 20, 2024

machine424 commented Dec 23, 2024

machine424 commented Dec 23, 2024

machine424 commented Jan 6, 2025

machine424 commented Jan 6, 2025

machine424 Jan 8, 2025

Choose a reason for hiding this comment

machine424 commented Jan 8, 2025

machine424 commented Jan 8, 2025

machine424 commented Jan 9, 2025

machine424 commented Jan 9, 2025

openshift-ci bot commented Jan 9, 2025

machine424 commented Sep 25, 2024 •

edited

Loading