Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update month0 variable name to month #97

Open
aj3sh opened this issue Dec 17, 2024 · 0 comments
Open

refactor: update month0 variable name to month #97

aj3sh opened this issue Dec 17, 2024 · 0 comments

Comments

@aj3sh
Copy link
Member

aj3sh commented Dec 17, 2024

We have used month0 as a variable to indicate that the first month starts at 0. However, there has been inconsistency in its usage. In some places, we use month with 0 as the first month, in others, we use month0, and elsewhere, month with 1 as the first month.

Let's refactor the entire codebase to use month consistently, where the first month starts at 0 (e.g., Baishakh and January). We also need to update all variable names and references where both month and month0 have been used inconsistently, including JSDoc comments where month0 has been mentioned.

/**
* dateConverter.ts
* ...
* Note: There are two types of month variables used in this file.
* The first is `month0`, which represents month values starting from 0,
* for example, 0 for January and 0 for Baishakh.
* The second is `month`, which represents month values starting from 1.
*/
@sugat009 sugat009 changed the title reafactor: update month0 variable name to month refactor: update month0 variable name to month Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant