Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add method formatEnglishDate and formatEnglishDateInNepali #94

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: add method formatEnglishDate and formatEnglishDateInNepali #94

merged 1 commit into from
Nov 22, 2024

Conversation

aj3sh
Copy link
Member

@aj3sh aj3sh commented Nov 20, 2024 •
edited
Loading

Description

  • Added method formatEnglishDate and formatEnglishDateInNepali.
  • Added tests for formatEnglishDate and formatEnglishDateInNepali (100% code coverage).
  • Updated NepaliDate AM/PM format with एम (AM) and पिम (PM). Fixes Can we decide what to use for AM and PM in the format token? #93
  • Renamed some constants to fit both English and Nepali data.

Impacts

The changes impact format and formatNepali methods; however, both methods are verified by the tests.

Related Issue

Relates #78

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.
  • My pull request has a clear title and description.

Additional Notes

[Add any additional notes or context that you think the reviewers should know about.]

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@aj3sh aj3sh added the enhancement New feature or request label Nov 20, 2024
@aj3sh aj3sh mentioned this pull request Nov 20, 2024
Closed
@aj3sh aj3sh force-pushed the formatEnglishDate branch from 8d0e5dd to 141d2e6 Compare November 20, 2024 15:23
@aj3sh aj3sh requested a review from subashcs November 21, 2024 08:57
@binodnepali
Copy link
Member

Thanks for the fix @aj3sh

@aj3sh aj3sh merged commit 6cf9d14 into opensource-nepal:main Nov 22, 2024
3 checks passed
@aj3sh aj3sh deleted the formatEnglishDate branch November 22, 2024 14:20
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugat009 sugat009 sugat009 approved these changes

@binodnepali binodnepali binodnepali approved these changes

@subashcs subashcs Awaiting requested review from subashcs

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we decide what to use for AM and PM in the format token?
3 participants
@aj3sh @binodnepali @sugat009