Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clear Data Activity #2797

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Implement Clear Data Activity #2797

wants to merge 14 commits into from

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented Oct 4, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

  • Set android:allowBackup manifest flag to false
  • Set android:hasFragileUserData to true
  • Add DataActivity to control app's data clearing action
  • Add android:manageSpaceActivity manifest setting and activity

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

- Set android:hasFragileUserData to true
- Add DataActivity to control app's data clearing action
- Add android:manageSpaceActivity setting and activity
@qiarie qiarie added the DNM DO NOT MERGE label Oct 4, 2023
- Add replace allowBackup manifest config
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: Patch coverage is 0% with 155 lines in your changes missing coverage. Please review.

Project coverage is 26.9%. Comparing base (83bb186) to head (a5100a4).

Files with missing lines Patch % Lines
...ter/fhircore/quest/ui/cleardata/ClearDataScreen.kt 0.0% 76 Missing ⚠️
.../fhircore/quest/ui/cleardata/ClearDataViewModel.kt 0.0% 64 Missing ⚠️
...r/fhircore/quest/ui/cleardata/ClearDataActivity.kt 0.0% 14 Missing ⚠️
...rcore/engine/util/extension/FhirEngineExtension.kt 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2797     +/-   ##
=========================================
- Coverage     27.2%   26.9%   -0.3%     
  Complexity     756     756             
=========================================
  Files          278     281      +3     
  Lines        14219   14374    +155     
  Branches      2581    2604     +23     
=========================================
  Hits          3880    3880             
- Misses        9801    9956    +155     
  Partials       538     538             
Flag Coverage Δ
engine 63.7% <0.0%> (-0.1%) ⬇️
geowidget 15.4% <ø> (ø)
quest 5.5% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rcore/engine/util/extension/FhirEngineExtension.kt 57.6% <0.0%> (-1.2%) ⬇️
...r/fhircore/quest/ui/cleardata/ClearDataActivity.kt 0.0% <0.0%> (ø)
.../fhircore/quest/ui/cleardata/ClearDataViewModel.kt 0.0% <0.0%> (ø)
...ter/fhircore/quest/ui/cleardata/ClearDataScreen.kt 0.0% <0.0%> (ø)

@ellykits
Copy link
Collaborator

Can you provide the link to the issue?

@qiarie
Copy link
Contributor Author

qiarie commented Nov 27, 2023

@ellykits This is the roadmap issue this is tied to Persist App data after uninstall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants