Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt Shared Preferences #688

Merged
merged 24 commits into from
Feb 9, 2021
Merged

Encrypt Shared Preferences #688

merged 24 commits into from
Feb 9, 2021

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented Nov 12, 2020 •
edited
Loading

  • Add option to encrypt SharedPreferences
  • Add support for migration of existing installs

@qiarie qiarie requested review from githengi and ndegwamartin and removed request for githengi November 12, 2020 09:57
@qiarie qiarie marked this pull request as ready for review November 18, 2020 10:29
@coveralls
Copy link

coveralls commented Nov 18, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 66.752% when pulling a1e7d1e on encrypt-shared-preferences into b78069d on master.

@qiarie qiarie force-pushed the encrypt-shared-preferences branch 2 times, most recently from 0871257 to 7852ba9 Compare November 19, 2020 10:21
@qiarie qiarie requested a review from githengi November 20, 2020 07:31
@qiarie qiarie force-pushed the encrypt-shared-preferences branch 2 times, most recently from dddca6c to 5a13930 Compare December 7, 2020 12:56
Andati
Andati previously approved these changes Dec 7, 2020
View reviewed changes
@ndegwamartin
Copy link
Contributor

@qiarie We'll need to add support for migration of existing installs. Check out the issue #719

@ndegwamartin ndegwamartin force-pushed the encrypt-shared-preferences branch 2 times, most recently from 2158242 to f396f29 Compare December 14, 2020 09:13
@qiarie qiarie force-pushed the encrypt-shared-preferences branch 2 times, most recently from b2e0c23 to 6ff900c Compare January 15, 2021 14:05
ndegwamartin
ndegwamartin previously approved these changes Jan 15, 2021
View reviewed changes
@qiarie qiarie closed this Feb 2, 2021
@qiarie qiarie reopened this Feb 2, 2021
@qiarie
Add androidx.security dependency
5b32135 
- Update minimum SDK to 23
- Update SharedPrefences dependency to androidx.preferences
@qiarie
Add encrypted SharedPreferences option
17a8960
@qiarie
Add encryptSharedPreferences flag to SyncConfiguration
f83a8d9
@qiarie
Update CryptographicHelperTest build version to M
74a75f7
@qiarie
Update dependency to androidx.preferences
3ddd933
@qiarie
Remove unused import
ab006d6
@qiarie
Restore minimum SDK version to 18
816a68f 
- Override minimum SDK requirement for androidx.security
@qiarie
Update security-crypto library to 1.0.0-rc03
a827692
@qiarie
Use EncryptedSharedPreferences for Android M+ only
d817703
@qiarie
Replace userService getAllSharedPreferences with context allSharedPre…
b1ac023 
…ferences
@qiarie
Revert CryptographicHelperTest tests to run on LOLLIPOP_MR1
3b66c39
@qiarie
Fix unit tests
f75727d
@qiarie
Fallback to unencrypted SharedPreferences on exception
e60e802
@qiarie
Add unit tests
8d58178
@qiarie
Update unit tests
9363209
@qiarie
Fix broken unit tests
3d66837
@qiarie
Override encryptSharedPreferences sync configuration in sample
3e4e148
@qiarie
Fix broken test
df9adc5
@qiarie
Rebase off master
a0ff043
@qiarie
Allow for shared prefs upgrade
86cd068
@qiarie
Bug fix
5eb8b59
@qiarie
Add encrypted shared prefs config to properties
efe597b 
- Remove encrypted shared prefs from SyncConfiguration
@qiarie
Fix unit tests
b93a52f
@qiarie qiarie merged commit 4dae553 into master Feb 9, 2021
@qiarie qiarie deleted the encrypt-shared-preferences branch February 9, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegwamartin ndegwamartin ndegwamartin approved these changes

@Andati Andati Andati left review comments

@githengi githengi Awaiting requested review from githengi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiarie @coveralls @ndegwamartin @Andati @githengi