Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSDEV-1374] SLC. Connect search & result page for name and address search with Backend API (integration) #483

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Innavin369
Copy link
Contributor

@Innavin369 Innavin369 commented Jan 13, 2025

OSDEV-1374 Implemented integration for the Search results page to show results of searching by name and address (/contribute/production-location/search):

- Connected GET `v1/production-locations`.
- Routing between pages `Production Location Search`,`Search returned no results`, `Production Location Information`, `Search results`, and `I don't see my Location` pop-up is configured.
- Max result limit set to 100

Notes: I recommend avoiding loading 20 locations for each iteration of scrolling since the maximum limit is capped at 100 locations. On my end, the endpoint executes locally within 300-500 milliseconds, and the scroll works smoothly. Given this, I believe further complicating the component’s logic is unnecessary.

@Innavin369 Innavin369 self-assigned this Jan 13, 2025
@Innavin369 Innavin369 marked this pull request as draft January 13, 2025 14:16
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:18 — with GitHub Actions Inactive
Copy link

barecheck bot commented Jan 13, 2025

React App | Jest test suite - Code coverage report

Total: 28.37%

Your code coverage diff: 0.06% ▴

✅ All code changes are covered

@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:22 — with GitHub Actions Inactive
Copy link

barecheck bot commented Jan 13, 2025

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:23 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:23 — with GitHub Actions Inactive
Copy link

barecheck bot commented Jan 13, 2025

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link

barecheck bot commented Jan 13, 2025

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@Innavin369 Innavin369 temporarily deployed to Quality Environment January 13, 2025 14:33 — with GitHub Actions Inactive
Copy link

barecheck bot commented Jan 13, 2025

Django App | Unittest test suite - Code coverage report

Total: 80.16%

Your code coverage diff: 0.07% ▴

✅ All code changes are covered

@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 13:34 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 13:38 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 13:39 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 13:39 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 13:49 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 17, 2025 15:10 — with GitHub Actions Inactive
@Innavin369
Copy link
Contributor Author

@VadimKovalenkoSNF regarding the request for the style. I've checked and realized that all buttons are the same size in the design, 200*49, except Search by OS ID. I think it makes sense to leave the styles of this button the same as the rest. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants