-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSDEV-1374] SLC. Connect search & result page for name and address search with Backend API (integration) #483
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # src/react/src/util/util.js
React App | Jest test suite - Code coverage reportTotal: 28.37%Your code coverage diff: 0.06% ▴ ✅ All code changes are covered |
Dedupe Hub App | Unittest test suite - Code coverage reportTotal: 56.14%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Countries App | Unittest test suite - Code coverage reportTotal: 100%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Contricleaner App | Unittest test suite - Code coverage reportTotal: 98.91%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Django App | Unittest test suite - Code coverage reportTotal: 80.16%Your code coverage diff: 0.07% ▴ ✅ All code changes are covered |
Quality Gate passedIssues Measures |
@VadimKovalenkoSNF regarding the request for the style. I've checked and realized that all buttons are the same size in the design, 200*49, except Search by OS ID. I think it makes sense to leave the styles of this button the same as the rest. What do you think? |
OSDEV-1374 Implemented integration for the
Search results
page to show results of searching by name and address (/contribute/production-location/search
):Notes: I recommend avoiding loading 20 locations for each iteration of scrolling since the maximum limit is capped at 100 locations. On my end, the endpoint executes locally within 300-500 milliseconds, and the scroll works smoothly. Given this, I believe further complicating the component’s logic is unnecessary.