Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate networking stuff into network.gd #98

Open
TheSecondReal0 opened this issue Oct 18, 2020 · 3 comments · Fixed by #122
Open

Consolidate networking stuff into network.gd #98

TheSecondReal0 opened this issue Oct 18, 2020 · 3 comments · Fixed by #122
Labels
feature New feature being added
Milestone

Comments

@TheSecondReal0
Copy link
Member

TheSecondReal0 commented Oct 18, 2020

Right now connection handling is split between main.gd and network.gd, when ideally it should all be in network.gd. This includes names, version checking, etc..

@monban monban added this to the Alpha milestone Oct 18, 2020
@vainiovano
Copy link
Contributor

Should players' names (and colors) be in network.gd or in player.gd? Each player has a name and color, and they need to be used for rendering.

@TheSecondReal0
Copy link
Member Author

I think names should be stored in network.gd just so that they're accessible from anywhere, same with colors. Probably in dictionaries where names and colors are stored according to player IDs.

@monban
Copy link
Member

monban commented Oct 19, 2020

As per @TheSecondReal0, this issue should not be closed yet.

@monban monban reopened this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature being added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants