Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve service callout links with useBaseUrl hook #145

Conversation

MJZLOTR
Copy link
Contributor

@MJZLOTR MJZLOTR commented Oct 22, 2024

No description provided.

@MJZLOTR MJZLOTR linked an issue Oct 22, 2024 that may be closed by this pull request
@MJZLOTR MJZLOTR temporarily deployed to pull-requests-preview October 22, 2024 13:50 — with GitHub Actions Inactive
Copy link

github-actions bot commented Oct 22, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-03 13:20 UTC

@MJZLOTR MJZLOTR temporarily deployed to pull-requests-preview October 22, 2024 13:58 — with GitHub Actions Inactive
@MJZLOTR MJZLOTR requested a review from akyriako October 22, 2024 14:05
Copy link
Member

@akyriako akyriako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MJZLOTR Add the same thing to the button "Explore our Best Practices" in the landing page

@akyriako
Copy link
Member

@MJZLOTR the fix is missing still in some spots!

@akyriako akyriako assigned akyriako and MJZLOTR and unassigned akyriako Nov 26, 2024
@MJZLOTR
Copy link
Contributor Author

MJZLOTR commented Nov 28, 2024

@akyriako It seems like that the PR Preview Action is disabled.

@MJZLOTR MJZLOTR temporarily deployed to pull-requests-preview December 3, 2024 13:11 — with GitHub Actions Inactive
@MJZLOTR MJZLOTR temporarily deployed to pull-requests-preview December 3, 2024 13:14 — with GitHub Actions Inactive
@MJZLOTR MJZLOTR requested a review from akyriako December 3, 2024 13:19
@MJZLOTR MJZLOTR added the gate gate it label Dec 3, 2024
@otc-zuul otc-zuul bot merged commit 9f831d1 into main Dec 3, 2024
7 checks passed
@otc-zuul otc-zuul bot deleted the 131-add-baseurl-in-service-callouts-href-in-pr-preview-environments branch December 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate gate it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BaseUrl in Service Callouts Href in PR-Preview Environments
3 participants