Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(float-button): [float-button] add float-button #1394

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

fanbingbing16
Copy link
Contributor

@fanbingbing16 fanbingbing16 commented Feb 13, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

增加悬浮按钮组件
Issue Number: #1346

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tiny-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 10:44am

@kagol
Copy link
Member

kagol commented Feb 20, 2024

@fanbingbing16 网站预览任务失败了,你merge下dev分支最新代码应该就好了
image

Copy link

vercel bot commented Feb 20, 2024

@fanbingbing16 is attempting to deploy a commit to the OpenTiny Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Deploy PR preview failed.

@fanbingbing16
Copy link
Contributor Author

@fanbingbing16 网站预览任务失败了,你merge下dev分支最新代码应该就好了 image

已merge

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@fanbingbing16 The website preview task failed. You should just merge the latest code from the dev branch! [image](https://private-user-images.githubusercontent.com/9566362/306156973-a38f4b80-3322-4b3f-82a0 -4e744ce7e1ef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9..5j0kJiVJnsUZw82paiy8oRBCtrFZJ0toRCXrtJoPPeM)

Already merged

@kagol kagol merged commit 1019e57 into opentiny:dev Feb 27, 2024
4 of 5 checks passed
@kagol
Copy link
Member

kagol commented Feb 27, 2024

@fanbingbing16 我先合入了,后续可以完善下 e2e 测试用例

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@fanbingbing16 I merged it first, and I can improve the e2e test case later.

@fanbingbing16
Copy link
Contributor Author

@fanbingbing16 我先合入了,后续可以完善下 e2e 测试用例

好的,我会找时间写的

@fanbingbing16 fanbingbing16 deleted the fanbingbing/feat-float-button branch February 28, 2024 07:35
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@fanbingbing16 I merged it first, and I can improve the e2e test case later.

Okay, I will find time to write it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants