Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rich-text-editor): [rich-text-editor] add image drag adjustment #1504

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

HAOUEHF
Copy link
Contributor

@HAOUEHF HAOUEHF commented Mar 21, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 1498

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Mar 21, 2024

@HAOUEHF is attempting to deploy a commit to the OpenTiny Team on Vercel.

A member of the Team first needs to authorize it.

@shenjunjian
Copy link
Collaborator

十分感谢提供新的插入图形拖拽大小的功能,基本可用。
但我实际测试遇到2个问题:
1、初始插入后,resize的大小固定为200*200 , 简单拖动一下,就立即贴合图片了,不那么方便
image

2、插入多个图片,或多次插入同一张图片总不太顺手,有时候不行,不明白为什么。

可否再排查下原因 @HAOUEHF

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Thank you very much for providing the new drag-and-drop function for inserting graphics, which is basically available.
But I encountered 2 problems in actual testing:

  1. After the initial insertion, the resize size is fixed at 200*200. Simply drag it and it will fit the picture immediately, which is not so convenient.
    image

  2. Inserting multiple pictures or inserting the same picture multiple times is not always easy. Sometimes it doesn’t work and I don’t understand why.

Can you check the reason again @HAOUEHF

@HAOUEHF
Copy link
Contributor Author

HAOUEHF commented Mar 22, 2024

@shenjunjian 没问题,我优化一下

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@shenjunjian No problem, I’ll optimize it

@HAOUEHF
Copy link
Contributor Author

HAOUEHF commented Mar 23, 2024

@shenjunjian 图片初始化大小改为400,优化多张图片插入问题、图片拖拽最大宽度不能超出富文本编辑器的宽度,后续会继续参与富文本的开发优化

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


@shenjunjian The initial image size is changed to 400 to optimize the problem of inserting multiple images. The maximum width of image dragging cannot exceed the width of the rich text editor. We will continue to participate in the development and optimization of rich text in the future.

@HAOUEHF
Copy link
Contributor Author

HAOUEHF commented Mar 26, 2024

@all-contributors please add @星河 for code

Copy link
Contributor

@HAOUEHF

Could not find the user 星河 on github.

@HAOUEHF
Copy link
Contributor Author

HAOUEHF commented Mar 26, 2024

@all-contributors please add @HAOUEHF for code

Copy link
Contributor

@HAOUEHF

I've put up a pull request to add @HAOUEHF! 🎉

@kagol kagol added the enhancement New feature or request label Mar 27, 2024
@zzcr zzcr merged commit e419936 into opentiny:dev Mar 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants