-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modal): [modal]switch browser address, error triggered close event issue when Modal is closed #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@James-9696 is attempting to deploy a commit to the OpenTiny Team on Vercel. A member of the Team first needs to authorize it. |
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
James-9696
changed the title
feat: switch browser address, error triggered close event issue when …
feat: switch browser address, error triggered close event issue when Modal is closed
Mar 18, 2024
James-9696
changed the title
feat: switch browser address, error triggered close event issue when Modal is closed
fix: switch browser address, error triggered close event issue when Modal is closed
Mar 18, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
James-9696
changed the title
fix: switch browser address, error triggered close event issue when Modal is closed
fix(modal): switch browser address, error triggered close event issue when Modal is closed
Mar 21, 2024
gimmyhehe
reviewed
Mar 25, 2024
James-9696
changed the title
fix(modal): switch browser address, error triggered close event issue when Modal is closed
fix(modal): [modal]switch browser address, error triggered close event issue when Modal is closed
Mar 25, 2024
AcWrong02
approved these changes
Mar 26, 2024
zzcr
approved these changes
Mar 30, 2024
kagol
added a commit
that referenced
this pull request
Mar 30, 2024
* feat(theme): update theme index * docs: add docs unplugin and changelog (#1476) * docs: add v3.14.0 changelog * chore: update @opentiny/unplugin-tiny-vue version * docs: add auto import docs * fix(vue): add new dependencies (#1482) * fix(vue): add new dependencies * fix(vue): add new dependencies * docs(grid): update grid apis (#1480) * Release 3.14.0 (#1494) * fix(docs): fix MindMap's menu text * fix(docs): update new components menu * feat: switch browser address, error triggered close event issue when Modal is closed (#1493) --------- Co-authored-by: Kagol <kagol@sina.com> Co-authored-by: gimmyhehe <975402925@qq.com> Co-authored-by: 申君健 <40288193@qq.com> Co-authored-by: James <72028410+James-9696@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Modal is closed
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information