Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): [modal]switch browser address, error triggered close event issue when Modal is closed #1493

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

James-9696
Copy link
Collaborator

@James-9696 James-9696 commented Mar 18, 2024

…Modal is closed

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Mar 18, 2024

@James-9696 is attempting to deploy a commit to the OpenTiny Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@James-9696 James-9696 changed the title feat: switch browser address, error triggered close event issue when … feat: switch browser address, error triggered close event issue when Modal is closed Mar 18, 2024
@James-9696 James-9696 changed the title feat: switch browser address, error triggered close event issue when Modal is closed fix: switch browser address, error triggered close event issue when Modal is closed Mar 18, 2024
@kagol kagol added the bug Something isn't working label Mar 18, 2024
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tiny-vue ❌ Failed (Inspect) Mar 18, 2024 6:54am

@James-9696 James-9696 changed the title fix: switch browser address, error triggered close event issue when Modal is closed fix(modal): switch browser address, error triggered close event issue when Modal is closed Mar 21, 2024
@James-9696 James-9696 changed the title fix(modal): switch browser address, error triggered close event issue when Modal is closed fix(modal): [modal]switch browser address, error triggered close event issue when Modal is closed Mar 25, 2024
@zzcr zzcr merged commit bb8c724 into opentiny:release-3.14.0 Mar 30, 2024
11 of 19 checks passed
kagol added a commit that referenced this pull request Mar 30, 2024
* feat(theme): update theme index

* docs: add docs unplugin and changelog (#1476)

* docs: add v3.14.0 changelog

* chore: update @opentiny/unplugin-tiny-vue version

* docs: add auto import docs

* fix(vue): add new dependencies (#1482)

* fix(vue): add new dependencies

* fix(vue): add new dependencies

* docs(grid): update grid apis (#1480)

* Release 3.14.0 (#1494)

* fix(docs): fix MindMap's menu text

* fix(docs): update new components menu

* feat: switch browser address, error triggered close event issue when Modal is closed (#1493)

---------

Co-authored-by: Kagol <kagol@sina.com>
Co-authored-by: gimmyhehe <975402925@qq.com>
Co-authored-by: 申君健 <40288193@qq.com>
Co-authored-by: James <72028410+James-9696@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants