Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync release-3.16.0 to dev #1648

Merged
merged 22 commits into from
May 28, 2024
Merged

feat: sync release-3.16.0 to dev #1648

merged 22 commits into from
May 28, 2024

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented May 28, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Added divided: true property to action menu options for better visual separation.
    • Enhanced plugin configurations for Vite and Webpack to auto-import TinyVue components.
    • Introduced TinyVueResolver for better component integration with various build tools.
  • Bug Fixes

    • Numerous bug fixes across components like modal, dialog-box, carousel, grid, rich-text-editor, date-picker, and file-upload.
    • Corrected pane sorting issues in tab navigation.
  • Documentation

    • Updated documentation with new features, bug fixes, and performance optimizations.
  • Refactor

    • Improved action menu interface by making properties optional.
    • Refactored import paths and version handling in various files for better maintainability.
  • Chores

    • Updated package versions for multiple components to ensure compatibility and stability.
    • Changed CDN host URL for better reliability.

gimmyhehe and others added 22 commits April 10, 2024 15:09
* fix(grid): [grid] fix grid not emit filter-change bug

* fix(grid): [grid] fix grid not emit filter-change bug
* fix(action-menu): [action-menu] fix no divided bug

* fix(action-menu): [action-menu] fix no divided bug
…or usage in vue2 and vue3 (#1558)

* fix(tabs): [tabs] Fix the bug where the name is empty caused by using v-if in tabstem

* fix(tabs): [tabs] update renderless version

* fix(tabs): [tabs] Fix the issue with rendering in the default slot of Vue3

* fix(tabs): [tabs] Fix the issue of inconsistent highlighting when multiple V-ifs are used

* fix(tabs): [tabs] update opentiny/vue-tabs version
* fix(select): add showAllTextTag prop for select

* fix(select): update select  version in  package.json
…1631)

* fix: 修复面积图空数据报错问题

* fix: 修复图表高度设置为100%的高度异常问题

* fix: 修改boxplot图表案例引入
* fix: 修复chart图表的extend未生效问题

* fix: 优化图表extend逻辑

* fix: 优化图表extend逻辑
Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

Copy link

coderabbitai bot commented May 28, 2024

Walkthrough

The changes introduce various updates across multiple files, including making properties optional in the IItemData interface, adding new properties to menu configurations, renaming imports, adjusting plugin configurations, updating version numbers, and enhancing component imports. These modifications collectively enhance the flexibility, functionality, and maintainability of the codebase.

Changes

Files/Paths Change Summary
.../action-menu.js, .../action-menu.type.ts Made properties optional in the IItemData and IActonMenuOptionsItem interfaces.
.../basic-usage-composition-api.vue, .../basic-usage.vue Added divided: true to the '重启' option in action menu configurations.
.../vertical-composition-api.vue Renamed imported entity chartBoxplot to ChartBoxplot.
.../menus.js Renamed and reorganized menu labels and keys across various categories.
.../changelog.md Documented new features, bug fixes, and updates in version v2.16.0/v3.16.0 of tiny-vue.
.../import-components.md Adjusted plugin configurations for Vite and Webpack to auto-import components from TinyVue.
.../package.json Updated version numbers for various packages.
.../playground.html Updated CDN host URL in a script.
.../App.vue Updated version numbers and adjusted CDN paths for various resources.
.../index.ts Refactored to support dynamic component imports based on the build tool used.
.../tabs/index.ts Added getOrderedPanes function to handle pane ordering in tabs.
.../index.less Added import statement for mind-map.

Poem

In the land of code, where changes flow,
Properties optional, menus glow.
Version numbers rise, CDN paths align,
Components auto-import, oh how fine!
Tabs now sorted, panes in line,
TinyVue evolves, a masterpiece design.

🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kagol kagol merged commit a931e5f into dev May 28, 2024
9 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Outside diff range and nitpick comments (4)
examples/sites/demos/pc/menus.js (3)

135-135: Consider removing the 'Beta' mark from 'RichTextEditor' if it's stable.

This could enhance user trust in using the component.


204-204: Add a 'New' mark to 'Card' if it's a newly introduced component.

This could help users identify new features quickly.


242-242: Add a 'New' mark to 'Skeleton' if it's a newly introduced component.

This could help users identify new features quickly.

examples/sites/demos/pc/webdoc/changelog.md (1)

Line range hint 11-658: The use of bare URLs in the changelog entries should be replaced with more descriptive link text to improve accessibility and readability. Consider using Markdown link syntax to provide context about the link's destination, which can enhance the user experience and SEO.

- https://github.com/opentiny/tiny-vue/pull/1547
+ [View Pull Request](https://github.com/opentiny/tiny-vue/pull/1547)
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 65eb13e and 1613d08.
Files selected for processing (53)
  • examples/sites/demos/apis/action-menu.js (1 hunks)
  • examples/sites/demos/pc/app/action-menu/basic-usage-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/basic-usage.vue (1 hunks)
  • examples/sites/demos/pc/app/action-menu/webdoc/action-menu.cn.md (1 hunks)
  • examples/sites/demos/pc/app/autocomplete/webdoc/autocomplete.cn.md (1 hunks)
  • examples/sites/demos/pc/app/autocomplete/webdoc/autocomplete.en.md (1 hunks)
  • examples/sites/demos/pc/app/chart/boxplot/vertical-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/checkbox/webdoc/checkbox.cn.md (1 hunks)
  • examples/sites/demos/pc/app/checkbox/webdoc/checkbox.en.md (1 hunks)
  • examples/sites/demos/pc/app/color-picker/webdoc/color-picker.cn.md (1 hunks)
  • examples/sites/demos/pc/app/color-select-panel/webdoc/color-select-panel.cn.md (1 hunks)
  • examples/sites/demos/pc/app/config-provider/webdoc/config-provider.cn.md (1 hunks)
  • examples/sites/demos/pc/app/config-provider/webdoc/config-provider.en.md (1 hunks)
  • examples/sites/demos/pc/app/container/webdoc/container.cn.md (1 hunks)
  • examples/sites/demos/pc/app/container/webdoc/container.en.md (1 hunks)
  • examples/sites/demos/pc/app/divider/webdoc/divider.cn.md (1 hunks)
  • examples/sites/demos/pc/app/drop-times/webdoc/drop-times.cn.md (1 hunks)
  • examples/sites/demos/pc/app/floatbar/webdoc/floatbar.cn.md (1 hunks)
  • examples/sites/demos/pc/app/floatbar/webdoc/floatbar.en.md (1 hunks)
  • examples/sites/demos/pc/app/flowchart/webdoc/flowchart.cn.md (1 hunks)
  • examples/sites/demos/pc/app/flowchart/webdoc/flowchart.en.md (1 hunks)
  • examples/sites/demos/pc/app/fullscreen/webdoc/fullscreen.cn.md (1 hunks)
  • examples/sites/demos/pc/app/image/webdoc/image.cn.md (1 hunks)
  • examples/sites/demos/pc/app/image/webdoc/image.en.md (1 hunks)
  • examples/sites/demos/pc/app/infinite-scroll/webdoc/infinite-scroll.cn.md (1 hunks)
  • examples/sites/demos/pc/app/layout/webdoc/layout.cn.md (1 hunks)
  • examples/sites/demos/pc/app/link/webdoc/link.cn.md (1 hunks)
  • examples/sites/demos/pc/app/link/webdoc/link.en.md (1 hunks)
  • examples/sites/demos/pc/app/numeric/webdoc/numeric.cn.md (1 hunks)
  • examples/sites/demos/pc/app/numeric/webdoc/numeric.en.md (1 hunks)
  • examples/sites/demos/pc/app/pager/webdoc/pager.cn.md (1 hunks)
  • examples/sites/demos/pc/app/pager/webdoc/pager.en.md (1 hunks)
  • examples/sites/demos/pc/app/pop-upload/webdoc/pop-upload.cn.md (1 hunks)
  • examples/sites/demos/pc/app/popconfirm/webdoc/popconfirm.cn.md (1 hunks)
  • examples/sites/demos/pc/app/popover/webdoc/popover.cn.md (1 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/webdoc/rich-text-editor.cn.md (1 hunks)
  • examples/sites/demos/pc/app/statistic/webdoc/statistic.cn.md (1 hunks)
  • examples/sites/demos/pc/app/time-line/webdoc/time-line.cn.md (1 hunks)
  • examples/sites/demos/pc/app/time-select/webdoc/time-select.cn.md (1 hunks)
  • examples/sites/demos/pc/menus.js (5 hunks)
  • examples/sites/demos/pc/webdoc/changelog.md (2 hunks)
  • examples/sites/demos/pc/webdoc/import-components.md (2 hunks)
  • examples/sites/package.json (3 hunks)
  • examples/sites/playground.html (1 hunks)
  • examples/sites/playground/App.vue (4 hunks)
  • internals/unplugin-tiny-vue/package.json (2 hunks)
  • internals/unplugin-tiny-vue/src/index.ts (1 hunks)
  • packages/renderless/package.json (2 hunks)
  • packages/renderless/src/tabs/index.ts (2 hunks)
  • packages/renderless/types/action-menu.type.ts (1 hunks)
  • packages/theme-saas/package.json (1 hunks)
  • packages/theme-saas/src/index.less (1 hunks)
  • packages/theme/package.json (2 hunks)
Files not processed due to max files limit (13)
  • packages/theme/src/chart-core/index.less
  • packages/theme/src/drop-times/index.less
  • packages/theme/src/grid/table.less
  • packages/vue/src/action-menu/package.json
  • packages/vue/src/action-menu/src/pc.vue
  • packages/vue/src/chart/chart-core/common/extend.ts
  • packages/vue/src/chart/chart-core/package.json
  • packages/vue/src/chart/chart-core/src/chart-core.ts
  • packages/vue/src/select/package.json
  • packages/vue/src/select/src/index.ts
  • packages/vue/src/select/src/pc.vue
  • packages/vue/src/tabs/package.json
  • packages/vue/src/tabs/src/tab-nav/pc.vue
Files skipped from review due to trivial changes (10)
  • examples/sites/demos/apis/action-menu.js
  • examples/sites/demos/pc/app/action-menu/basic-usage-composition-api.vue
  • examples/sites/demos/pc/app/action-menu/basic-usage.vue
  • examples/sites/demos/pc/app/chart/boxplot/vertical-composition-api.vue
  • examples/sites/playground.html
  • internals/unplugin-tiny-vue/package.json
  • packages/renderless/package.json
  • packages/theme-saas/package.json
  • packages/theme-saas/src/index.less
  • packages/theme/package.json
Additional Context Used
Markdownlint (590)
examples/sites/demos/pc/app/action-menu/webdoc/action-menu.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/autocomplete/webdoc/autocomplete.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/autocomplete/webdoc/autocomplete.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/checkbox/webdoc/checkbox.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/checkbox/webdoc/checkbox.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/color-picker/webdoc/color-picker.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/color-select-panel/webdoc/color-select-panel.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/config-provider/webdoc/config-provider.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/config-provider/webdoc/config-provider.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/container/webdoc/container.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/container/webdoc/container.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/divider/webdoc/divider.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/drop-times/webdoc/drop-times.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/floatbar/webdoc/floatbar.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/floatbar/webdoc/floatbar.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/flowchart/webdoc/flowchart.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/flowchart/webdoc/flowchart.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/fullscreen/webdoc/fullscreen.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/image/webdoc/image.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/image/webdoc/image.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/infinite-scroll/webdoc/infinite-scroll.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/layout/webdoc/layout.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/link/webdoc/link.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/link/webdoc/link.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/numeric/webdoc/numeric.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/numeric/webdoc/numeric.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/pager/webdoc/pager.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/pager/webdoc/pager.en.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/pop-upload/webdoc/pop-upload.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/popconfirm/webdoc/popconfirm.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/popover/webdoc/popover.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/rich-text-editor/webdoc/rich-text-editor.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/statistic/webdoc/statistic.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/time-line/webdoc/time-line.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/app/time-select/webdoc/time-select.cn.md (1)

5: null
Multiple top-level headings in the same document

examples/sites/demos/pc/webdoc/changelog.md (555)

11: null
Bare URL used


12: null
Bare URL used


13: null
Bare URL used


14: null
Bare URL used


15: null
Bare URL used


19: null
Bare URL used


20: null
Bare URL used


21: null
Bare URL used


22: null
Bare URL used


23: null
Bare URL used


24: null
Bare URL used


25: null
Bare URL used


26: null
Bare URL used


27: null
Bare URL used


28: null
Bare URL used


29: null
Bare URL used


30: null
Bare URL used


31: null
Bare URL used


32: null
Bare URL used


33: null
Bare URL used


37: null
Bare URL used


38: null
Bare URL used


39: null
Bare URL used


40: null
Bare URL used


41: null
Bare URL used


42: null
Bare URL used


43: null
Bare URL used


44: null
Bare URL used


45: null
Bare URL used


46: null
Bare URL used


47: null
Bare URL used


48: null
Bare URL used


52: null
Bare URL used


53: null
Bare URL used


54: null
Bare URL used


65: null
Bare URL used


66: null
Bare URL used


67: null
Bare URL used


68: null
Bare URL used


69: null
Bare URL used


70: null
Bare URL used


71: null
Bare URL used


72: null
Bare URL used


73: null
Bare URL used


74: null
Bare URL used


75: null
Bare URL used


86: null
Bare URL used


87: null
Bare URL used


88: null
Bare URL used


89: null
Bare URL used


90: null
Bare URL used


91: null
Bare URL used


92: null
Bare URL used


93: null
Bare URL used


101: null
Bare URL used


102: null
Bare URL used


103: null
Bare URL used


104: null
Bare URL used


105: null
Bare URL used


106: null
Bare URL used


107: null
Bare URL used


108: null
Bare URL used


109: null
Bare URL used


110: null
Bare URL used


111: null
Bare URL used


112: null
Bare URL used


113: null
Bare URL used


114: null
Bare URL used


118: null
Bare URL used


128: null
Bare URL used


129: null
Bare URL used


130: null
Bare URL used


132: null
Bare URL used


133: null
Bare URL used


134: null
Bare URL used


135: null
Bare URL used


136: null
Bare URL used


137: null
Bare URL used


138: null
Bare URL used


139: null
Bare URL used


140: null
Bare URL used


141: null
Bare URL used


142: null
Bare URL used


143: null
Bare URL used


144: null
Bare URL used


145: null
Bare URL used


146: null
Bare URL used


147: null
Bare URL used


148: null
Bare URL used


149: null
Bare URL used


150: null
Bare URL used


151: null
Bare URL used


152: null
Bare URL used


153: null
Bare URL used


154: null
Bare URL used


155: null
Bare URL used


156: null
Bare URL used


157: null
Bare URL used


158: null
Bare URL used


159: null
Bare URL used


160: null
Bare URL used


161: null
Bare URL used


162: null
Bare URL used


163: null
Bare URL used


164: null
Bare URL used


168: null
Bare URL used


169: null
Bare URL used


170: null
Bare URL used


171: null
Bare URL used


172: null
Bare URL used


173: null
Bare URL used


174: null
Bare URL used


175: null
Bare URL used


176: null
Bare URL used


177: null
Bare URL used


178: null
Bare URL used


179: null
Bare URL used


180: null
Bare URL used


181: null
Bare URL used


182: null
Bare URL used


183: null
Bare URL used


184: null
Bare URL used


185: null
Bare URL used


186: null
Bare URL used


187: null
Bare URL used


188: null
Bare URL used


189: null
Bare URL used


190: null
Bare URL used


191: null
Bare URL used


192: null
Bare URL used


193: null
Bare URL used


194: null
Bare URL used


195: null
Bare URL used


196: null
Bare URL used


197: null
Bare URL used


201: null
Bare URL used


202: null
Bare URL used


203: null
Bare URL used


204: null
Bare URL used


205: null
Bare URL used


206: null
Bare URL used


207: null
Bare URL used


208: null
Bare URL used


209: null
Bare URL used


210: null
Bare URL used


211: null
Bare URL used


212: null
Bare URL used


213: null
Bare URL used


214: null
Bare URL used


215: null
Bare URL used


216: null
Bare URL used


217: null
Bare URL used


218: null
Bare URL used


219: null
Bare URL used


220: null
Bare URL used


221: null
Bare URL used


222: null
Bare URL used


223: null
Bare URL used


224: null
Bare URL used


225: null
Bare URL used


226: null
Bare URL used


227: null
Bare URL used


228: null
Bare URL used


229: null
Bare URL used


230: null
Bare URL used


231: null
Bare URL used


232: null
Bare URL used


233: null
Bare URL used


234: null
Bare URL used


235: null
Bare URL used


236: null
Bare URL used


237: null
Bare URL used


238: null
Bare URL used


239: null
Bare URL used


240: null
Bare URL used


241: null
Bare URL used


242: null
Bare URL used


243: null
Bare URL used


244: null
Bare URL used


245: null
Bare URL used


246: null
Bare URL used


247: null
Bare URL used


248: null
Bare URL used


249: null
Bare URL used


250: null
Bare URL used


251: null
Bare URL used


255: null
Bare URL used


256: null
Bare URL used


257: null
Bare URL used


267: null
Bare URL used


268: null
Bare URL used


269: null
Bare URL used


270: null
Bare URL used


271: null
Bare URL used


272: null
Bare URL used


273: null
Bare URL used


274: null
Bare URL used


275: null
Bare URL used


276: null
Bare URL used


277: null
Bare URL used


278: null
Bare URL used


279: null
Bare URL used


280: null
Bare URL used


281: null
Bare URL used


282: null
Bare URL used


283: null
Bare URL used


284: null
Bare URL used


285: null
Bare URL used


286: null
Bare URL used


287: null
Bare URL used


288: null
Bare URL used


289: null
Bare URL used


290: null
Bare URL used


291: null
Bare URL used


292: null
Bare URL used


293: null
Bare URL used


294: null
Bare URL used


298: null
Bare URL used


299: null
Bare URL used


300: null
Bare URL used


301: null
Bare URL used


302: null
Bare URL used


303: null
Bare URL used


304: null
Bare URL used


305: null
Bare URL used


306: null
Bare URL used


307: null
Bare URL used


308: null
Bare URL used


309: null
Bare URL used


310: null
Bare URL used


311: null
Bare URL used


312: null
Bare URL used


313: null
Bare URL used


314: null
Bare URL used


315: null
Bare URL used


316: null
Bare URL used


317: null
Bare URL used


318: null
Bare URL used


319: null
Bare URL used


320: null
Bare URL used


321: null
Bare URL used


322: null
Bare URL used


323: null
Bare URL used


324: null
Bare URL used


325: null
Bare URL used


326: null
Bare URL used


327: null
Bare URL used


328: null
Bare URL used


329: null
Bare URL used


330: null
Bare URL used


331: null
Bare URL used


332: null
Bare URL used


333: null
Bare URL used


334: null
Bare URL used


335: null
Bare URL used


336: null
Bare URL used


337: null
Bare URL used


338: null
Bare URL used


339: null
Bare URL used


340: null
Bare URL used


341: null
Bare URL used


342: null
Bare URL used


343: null
Bare URL used


344: null
Bare URL used


345: null
Bare URL used


346: null
Bare URL used


350: null
Bare URL used


351: null
Bare URL used


352: null
Bare URL used


353: null
Bare URL used


354: null
Bare URL used


355: null
Bare URL used


356: null
Bare URL used


357: null
Bare URL used


358: null
Bare URL used


359: null
Bare URL used


360: null
Bare URL used


361: null
Bare URL used


362: null
Bare URL used


363: null
Bare URL used


364: null
Bare URL used


365: null
Bare URL used


366: null
Bare URL used


367: null
Bare URL used


368: null
Bare URL used


369: null
Bare URL used


370: null
Bare URL used


371: null
Bare URL used


372: null
Bare URL used


373: null
Bare URL used


374: null
Bare URL used


375: null
Bare URL used


376: null
Bare URL used


377: null
Bare URL used


378: null
Bare URL used


379: null
Bare URL used


380: null
Bare URL used


381: null
Bare URL used


382: null
Bare URL used


383: null
Bare URL used


384: null
Bare URL used


385: null
Bare URL used


386: null
Bare URL used


387: null
Bare URL used


388: null
Bare URL used


389: null
Bare URL used


390: null
Bare URL used


391: null
Bare URL used


392: null
Bare URL used


393: null
Bare URL used


394: null
Bare URL used


395: null
Bare URL used


396: null
Bare URL used


397: null
Bare URL used


398: null
Bare URL used


399: null
Bare URL used


400: null
Bare URL used


401: null
Bare URL used


402: null
Bare URL used


403: null
Bare URL used


404: null
Bare URL used


405: null
Bare URL used


406: null
Bare URL used


407: null
Bare URL used


408: null
Bare URL used


409: null
Bare URL used


410: null
Bare URL used


411: null
Bare URL used


412: null
Bare URL used


413: null
Bare URL used


414: null
Bare URL used


415: null
Bare URL used


416: null
Bare URL used


417: null
Bare URL used


418: null
Bare URL used


419: null
Bare URL used


420: null
Bare URL used


421: null
Bare URL used


422: null
Bare URL used


423: null
Bare URL used


424: null
Bare URL used


425: null
Bare URL used


426: null
Bare URL used


427: null
Bare URL used


428: null
Bare URL used


429: null
Bare URL used


430: null
Bare URL used


431: null
Bare URL used


432: null
Bare URL used


433: null
Bare URL used


434: null
Bare URL used


435: null
Bare URL used


436: null
Bare URL used


440: null
Bare URL used


441: null
Bare URL used


442: null
Bare URL used


443: null
Bare URL used


452: null
Bare URL used


453: null
Bare URL used


454: null
Bare URL used


455: null
Bare URL used


456: null
Bare URL used


457: null
Bare URL used


458: null
Bare URL used


459: null
Bare URL used


460: null
Bare URL used


461: null
Bare URL used


462: null
Bare URL used


463: null
Bare URL used


464: null
Bare URL used


465: null
Bare URL used


466: null
Bare URL used


467: null
Bare URL used


468: null
Bare URL used


469: null
Bare URL used


470: null
Bare URL used


471: null
Bare URL used


472: null
Bare URL used


473: null
Bare URL used


474: null
Bare URL used


475: null
Bare URL used


476: null
Bare URL used


477: null
Bare URL used


478: null
Bare URL used


479: null
Bare URL used


480: null
Bare URL used


481: null
Bare URL used


482: null
Bare URL used


483: null
Bare URL used


487: null
Bare URL used


488: null
Bare URL used


489: null
Bare URL used


490: null
Bare URL used


491: null
Bare URL used


492: null
Bare URL used


493: null
Bare URL used


494: null
Bare URL used


495: null
Bare URL used


496: null
Bare URL used


497: null
Bare URL used


498: null
Bare URL used


499: null
Bare URL used


500: null
Bare URL used


501: null
Bare URL used


502: null
Bare URL used


503: null
Bare URL used


504: null
Bare URL used


505: null
Bare URL used


506: null
Bare URL used


507: null
Bare URL used


508: null
Bare URL used


509: null
Bare URL used


510: null
Bare URL used


511: null
Bare URL used


512: null
Bare URL used


513: null
Bare URL used


514: null
Bare URL used


515: null
Bare URL used


516: null
Bare URL used


517: null
Bare URL used


518: null
Bare URL used


519: null
Bare URL used


520: null
Bare URL used


521: null
Bare URL used


522: null
Bare URL used


523: null
Bare URL used


524: null
Bare URL used


525: null
Bare URL used


526: null
Bare URL used


527: null
Bare URL used


528: null
Bare URL used


529: null
Bare URL used


530: null
Bare URL used


531: null
Bare URL used


532: null
Bare URL used


533: null
Bare URL used


534: null
Bare URL used


535: null
Bare URL used


536: null
Bare URL used


537: null
Bare URL used


538: null
Bare URL used


539: null
Bare URL used


540: null
Bare URL used


544: null
Bare URL used


545: null
Bare URL used


546: null
Bare URL used


547: null
Bare URL used


548: null
Bare URL used


549: null
Bare URL used


550: null
Bare URL used


551: null
Bare URL used


552: null
Bare URL used


553: null
Bare URL used


554: null
Bare URL used


555: null
Bare URL used


556: null
Bare URL used


557: null
Bare URL used


558: null
Bare URL used


559: null
Bare URL used


560: null
Bare URL used


561: null
Bare URL used


562: null
Bare URL used


563: null
Bare URL used


564: null
Bare URL used


565: null
Bare URL used


566: null
Bare URL used


567: null
Bare URL used


568: null
Bare URL used


569: null
Bare URL used


570: null
Bare URL used


571: null
Bare URL used


572: null
Bare URL used


573: null
Bare URL used


574: null
Bare URL used


575: null
Bare URL used


576: null
Bare URL used


577: null
Bare URL used


578: null
Bare URL used


579: null
Bare URL used


580: null
Bare URL used


581: null
Bare URL used


582: null
Bare URL used


583: null
Bare URL used


584: null
Bare URL used


585: null
Bare URL used


586: null
Bare URL used


587: null
Bare URL used


588: null
Bare URL used


589: null
Bare URL used


590: null
Bare URL used


591: null
Bare URL used


592: null
Bare URL used


593: null
Bare URL used


594: null
Bare URL used


595: null
Bare URL used


596: null
Bare URL used


597: null
Bare URL used


598: null
Bare URL used


599: null
Bare URL used


600: null
Bare URL used


601: null
Bare URL used


602: null
Bare URL used


603: null
Bare URL used


604: null
Bare URL used


605: null
Bare URL used


606: null
Bare URL used


607: null
Bare URL used


608: null
Bare URL used


609: null
Bare URL used


610: null
Bare URL used


611: null
Bare URL used


612: null
Bare URL used


613: null
Bare URL used


614: null
Bare URL used


615: null
Bare URL used


616: null
Bare URL used


617: null
Bare URL used


618: null
Bare URL used


619: null
Bare URL used


620: null
Bare URL used


621: null
Bare URL used


622: null
Bare URL used


623: null
Bare URL used


624: null
Bare URL used


625: null
Bare URL used


626: null
Bare URL used


627: null
Bare URL used


628: null
Bare URL used


629: null
Bare URL used


630: null
Bare URL used


631: null
Bare URL used


632: null
Bare URL used


633: null
Bare URL used


634: null
Bare URL used


635: null
Bare URL used


636: null
Bare URL used


637: null
Bare URL used


638: null
Bare URL used


639: null
Bare URL used


640: null
Bare URL used


641: null
Bare URL used


642: null
Bare URL used


643: null
Bare URL used


644: null
Bare URL used


645: null
Bare URL used


646: null
Bare URL used


647: null
Bare URL used


651: null
Bare URL used


652: null
Bare URL used


653: null
Bare URL used


654: null
Bare URL used


655: null
Bare URL used


656: null
Bare URL used


657: null
Bare URL used


658: null
Bare URL used

Biome (46)
examples/sites/demos/pc/menus.js (20)

11-11: The computed expression can be simplified without the use of a string literal.


11-11: The computed expression can be simplified without the use of a string literal.


11-11: The computed expression can be simplified without the use of a string literal.


12-12: The computed expression can be simplified without the use of a string literal.


12-12: The computed expression can be simplified without the use of a string literal.


12-13: The computed expression can be simplified without the use of a string literal.


13-13: The computed expression can be simplified without the use of a string literal.


13-13: The computed expression can be simplified without the use of a string literal.


14-14: The computed expression can be simplified without the use of a string literal.


14-14: The computed expression can be simplified without the use of a string literal.


14-14: The computed expression can be simplified without the use of a string literal.


16-16: The computed expression can be simplified without the use of a string literal.


17-17: The computed expression can be simplified without the use of a string literal.


19-19: The computed expression can be simplified without the use of a string literal.


20-20: The computed expression can be simplified without the use of a string literal.


25-26: The computed expression can be simplified without the use of a string literal.


27-27: The computed expression can be simplified without the use of a string literal.


28-28: The computed expression can be simplified without the use of a string literal.


31-31: The computed expression can be simplified without the use of a string literal.


32-32: The computed expression can be simplified without the use of a string literal.

internals/unplugin-tiny-vue/src/index.ts (5)

8-8: The computed expression can be simplified without the use of a string literal.


9-9: The computed expression can be simplified without the use of a string literal.


10-10: The computed expression can be simplified without the use of a string literal.


11-11: The computed expression can be simplified without the use of a string literal.


12-12: The computed expression can be simplified without the use of a string literal.

packages/renderless/src/tabs/index.ts (19)

20-20: This variable implicitly has the any type.


26-26: Change to an optional chain.


26-29: Change to an optional chain.


29-29: Change to an optional chain.


29-35: Change to an optional chain.


35-51: Prefer for...of instead of forEach.


43-47: Prefer for...of instead of forEach.


57-70: Prefer for...of instead of forEach.


83-94: Prefer for...of instead of forEach.


87-93: Prefer for...of instead of forEach.


101-102: The assignment should not be in an expression.


137-137: Change to an optional chain.


185-189: Change to an optional chain.


206-209: Change to an optional chain.


229-229: Change to an optional chain.


233-237: Change to an optional chain.


70-71: Reassigning a function parameter is confusing.


55-57: This let declares a variable that is only assigned once.


60-60: This let declares a variable that is only assigned once.

packages/renderless/types/action-menu.type.ts (2)

31-31: Unexpected any. Specify a different type.


32-32: Unexpected any. Specify a different type.

Additional comments not posted (43)
examples/sites/demos/pc/app/link/webdoc/link.cn.md (1)

2-5: The document structure appears correct with a single top-level heading, contrary to the static analysis warning.

examples/sites/demos/pc/app/link/webdoc/link.en.md (1)

2-5: The document structure is correct with a single top-level heading, contrary to the static analysis warning.

examples/sites/demos/pc/app/statistic/webdoc/statistic.cn.md (1)

2-5: The document structure is correct with a single top-level heading, contrary to the static analysis warning.

examples/sites/demos/pc/app/config-provider/webdoc/config-provider.en.md (1)

2-5: The document structure is correct with a single top-level heading, contrary to the static analysis warning.

examples/sites/demos/pc/app/time-line/webdoc/time-line.cn.md (1)

2-5: The document structure is correct with a single top-level heading, contrary to the static analysis warning.

examples/sites/demos/pc/app/config-provider/webdoc/config-provider.cn.md (1)

2-5: The document structure is correct with a single top-level heading, contrary to the static analysis warning.

examples/sites/demos/pc/app/fullscreen/webdoc/fullscreen.cn.md (1)

2-7: The changes in the document structure and content appear correct and well-formed.

examples/sites/demos/pc/app/pager/webdoc/pager.cn.md (1)

Line range hint 2-7: The updates to the document are clear and relevant to the component described.

examples/sites/demos/pc/app/pop-upload/webdoc/pop-upload.cn.md (1)

2-5: The documentation updates accurately reflect the functionality of the PopUpload component.

examples/sites/demos/pc/app/container/webdoc/container.cn.md (1)

2-5: The documentation for the Container layout is concise and informative.

examples/sites/demos/pc/app/autocomplete/webdoc/autocomplete.cn.md (1)

2-5: The updates to the AutoComplete documentation are clear and enhance the understanding of its functionality.

examples/sites/demos/pc/app/divider/webdoc/divider.cn.md (1)

2-7: The documentation for the Divider component is updated appropriately, enhancing clarity and detail.

examples/sites/demos/pc/app/checkbox/webdoc/checkbox.cn.md (1)

2-5: The documentation update looks good and is clear in its description.

examples/sites/demos/pc/app/floatbar/webdoc/floatbar.cn.md (1)

2-5: The documentation update looks good and is clear in its description.

examples/sites/demos/pc/app/layout/webdoc/layout.cn.md (1)

2-5: The documentation update looks good and is clear in its description.

examples/sites/demos/pc/app/color-picker/webdoc/color-picker.cn.md (1)

2-7: The documentation update looks good and is clear in its description.

examples/sites/demos/pc/app/infinite-scroll/webdoc/infinite-scroll.cn.md (1)

2-5: The documentation update looks good and is clear in its description.

examples/sites/demos/pc/app/image/webdoc/image.cn.md (1)

2-5: The documentation update looks good and is clear in its description.

examples/sites/demos/pc/app/popconfirm/webdoc/popconfirm.cn.md (1)

2-5: The documentation update for PopConfirm looks good and is clearly structured.

examples/sites/demos/pc/app/popover/webdoc/popover.cn.md (1)

2-5: The documentation update for Popover is clear and well-structured.

examples/sites/demos/pc/app/action-menu/webdoc/action-menu.cn.md (1)

2-5: The documentation update for ActionMenu is concise and informative.

examples/sites/demos/pc/app/color-select-panel/webdoc/color-select-panel.cn.md (1)

2-7: The documentation update for ColorSelectPanel is clear and matches the component's functionality.

examples/sites/demos/pc/app/numeric/webdoc/numeric.cn.md (1)

2-7: The documentation update for Numeric is detailed and appropriately describes the component's features.

examples/sites/demos/pc/app/autocomplete/webdoc/autocomplete.en.md (1)

2-5: The documentation update for AutoComplete is succinct and effectively communicates the component's functionality.

examples/sites/demos/pc/app/drop-times/webdoc/drop-times.cn.md (1)

2-5: The document structure appears correct with a single top-level heading, contrary to the static analysis hint.

examples/sites/demos/pc/app/time-select/webdoc/time-select.cn.md (1)

2-7: The document structure is correct with a single top-level heading. The static analysis hint about multiple headings does not apply here.

examples/sites/demos/pc/app/container/webdoc/container.en.md (1)

2-5: The document structure is correct with a single top-level heading. The static analysis hint about multiple headings does not apply here.

examples/sites/demos/pc/app/flowchart/webdoc/flowchart.cn.md (1)

2-5: The document structure is correct with a single top-level heading. The static analysis hint about multiple headings does not apply here.

examples/sites/demos/pc/app/rich-text-editor/webdoc/rich-text-editor.cn.md (1)

2-5: The document structure is correct with a single top-level heading. The static analysis hint about multiple headings does not apply here.

examples/sites/demos/pc/app/checkbox/webdoc/checkbox.en.md (1)

2-5: The document structure is correct with a single top-level heading. The static analysis hint about multiple headings does not apply here.

examples/sites/demos/pc/app/floatbar/webdoc/floatbar.en.md (1)

2-5: The title and description changes are clear and concise.

examples/sites/demos/pc/app/pager/webdoc/pager.en.md (1)

2-7: The title and description changes are informative and relevant.

examples/sites/demos/pc/app/flowchart/webdoc/flowchart.en.md (1)

2-5: The title and description changes are clear and concise.

examples/sites/demos/pc/app/image/webdoc/image.en.md (1)

2-5: The title and description changes are clear and concise.

examples/sites/demos/pc/app/numeric/webdoc/numeric.en.md (1)

2-7: The title and description changes are clear and concise.

internals/unplugin-tiny-vue/src/index.ts (1)

24-36: The function definition for the plugin is clear and well-documented.

packages/renderless/types/action-menu.type.ts (1)

34-42: Changes to IActionMenuState enhance flexibility and are consistent with updates to IActonMenuOptionsItem.

examples/sites/package.json (2)

3-3: Version update to 3.16.2 is noted and appropriate.


47-47: Verify the usage of @opentiny/vue-repl in the project to ensure it integrates well with existing components.

#!/bin/bash
# Description: Verify the usage of `@opentiny/vue-repl` in the project.

# Test: Search for the import and usage of `@opentiny/vue-repl` in JavaScript/TypeScript files. Expect: At least one occurrence.
rg --type js --type ts '@opentiny/vue-repl'
examples/sites/demos/pc/webdoc/import-components.md (2)

25-25: Updated Vite configuration to use autoImportPlugin simplifies component imports.


36-40: Updated Webpack configuration to use autoImportPlugin aligns with Vite changes and simplifies component imports.

examples/sites/playground/App.vue (1)

Line range hint 20-81: Updates to handle versions and themes dynamically in the playground are well-implemented and enhance user flexibility.

examples/sites/demos/pc/menus.js (1)

216-216: Verify the 'New' mark on 'MindMap' is appropriate.

Verification successful

The commit history indicates that the 'MindMap' component was marked as 'New' in a recent commit. This confirms that the 'New' mark on 'MindMap' is appropriate.

  • Commit 4f0fe09235879339ee06b9fb9be1e28a677bd630 on May 27, 2024, introduced the 'MindMap' component with the 'New' mark.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Check if 'MindMap' is a new component in this release.

# Test: Search for previous mentions of 'MindMap' to confirm its novelty.
rg --type json --files-with-matches $'MindMap' examples/sites/demos/pc/menus.js

Length of output: 111



Script:

#!/bin/bash
# Description: Check the commit history of the file to find when 'MindMap' was first introduced.

# Test: Use git log to find the first introduction of 'MindMap' in the file.
git log -p -G 'MindMap' -- examples/sites/demos/pc/menus.js

Length of output: 17527

Comment on lines +78 to +90
'label': '基础',
'labelEn': 'Basic',
'key': 'cmp_frame_style',
'children': [
{ 'nameCn': '按钮', 'name': 'Button', 'key': 'button' },
{ 'nameCn': '按钮组', 'name': 'ButtonGroup', 'key': 'button-group' },
{ 'nameCn': '色彩', 'name': 'Color', 'key': 'color' },
{ 'nameCn': '版型', 'name': 'Container', 'key': 'container' },
{ 'nameCn': '容器布局', 'name': 'Container', 'key': 'container' },
{ 'nameCn': '字体', 'name': 'Font', 'key': 'font' },
{ 'nameCn': '图标', 'name': 'Icon', 'key': 'icon' },
{ 'nameCn': '布局', 'name': 'Layout', 'key': 'layout' }
{ 'nameCn': '栅格布局', 'name': 'Layout', 'key': 'layout' },
{ 'nameCn': '链接', 'name': 'Link', 'key': 'link' },
{ 'nameCn': '分割线', 'name': 'Divider', 'key': 'divider' }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The extracted lines show that the menu items have varying properties such as nameCn, name, and key. However, there are inconsistencies in the properties used for different menu items. For example, some items use title and titleEn instead of nameCn and name.

To ensure consistency, all menu items should use the same set of properties. Here are the inconsistencies found:

  • Some items use title and titleEn instead of nameCn and name.
  • Some items have missing name properties.

Inconsistent Properties:

  • Lines 11-14, 31-32, 41-42: Use title and titleEn.
  • Lines 157-193: Missing name properties.

Action Required:

  • Ensure all menu items use nameCn, name, and key properties consistently.
  • Update items using title and titleEn to use nameCn and name.
  • Add missing name properties where applicable.

Locations to Update:

  • Lines 11-14, 31-32, 41-42
  • Lines 157-193
Analysis chain

Ensure consistency in menu item definitions.

Also applies to: 94-109, 113-149, 153-226, 229-244, 247-281, 281-296

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that all menu items have consistent properties and naming conventions.

# Test: Search for inconsistencies in menu item properties.
rg --type json --files-with-matches $'nameCn: .*, name: .*, key: .*' examples/sites/demos/pc/menus.js

Length of output: 102



Script:

#!/bin/bash
# Description: Extract all menu items and their properties for manual inspection.

# Extract all lines containing menu items and their properties.
rg --type json --no-heading --line-number 'nameCn|name|key' examples/sites/demos/pc/menus.js

Length of output: 13353

Comment on lines +8 to +12
'vite': AutoVite,
'webpack': AutoWebpack,
'rollup': AutoRollup,
'esbuild': AutoEsbuild,
'rspack': AutoRspack
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the computed expressions in the supportMap object.

-  'vite': AutoVite,
-  'webpack': AutoWebpack,
-  'rollup': AutoRollup,
-  'esbuild': AutoEsbuild,
-  'rspack': AutoRspack
+  vite: AutoVite,
+  webpack: AutoWebpack,
+  rollup: AutoRollup,
+  esbuild: AutoEsbuild,
+  rspack: AutoRspack

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
'vite': AutoVite,
'webpack': AutoWebpack,
'rollup': AutoRollup,
'esbuild': AutoEsbuild,
'rspack': AutoRspack
vite: AutoVite,
webpack: AutoWebpack,
rollup: AutoRollup,
esbuild: AutoEsbuild,
rspack: AutoRspack

Comment on lines +26 to +33
export interface IActonMenuOptionsItem {
label?: string
disabled?: boolean
divided?: boolean
children?: IActonMenuOptionsItem[]
icon?: any
[key: string]: any
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider replacing any with a more specific type for icon and index signature to enhance type safety.

-  icon?: any
-  [key: string]: any
+  icon?: IconType // Assuming IconType is defined elsewhere
+  [key: string]: SomeSpecificType // Replace SomeSpecificType with the actual type intended

Committable suggestion was skipped due low confidence.

Comment on lines +14 to +64
// 此处与aui区别开,将tabNav的方法抽离出来,从源头解决pane的排序问题
const getOrderedPanes = (parent, panes) => {
const slotDefault = parent.$slots.default
let orders

if (typeof slotDefault === 'function') {
orders = []

const tabVnodes = slotDefault()
const handler = ({ type, componentOptions, props }) => {
let componentName = type && type.componentName

if (!componentName) componentName = componentOptions && componentOptions.Ctor.extendOptions.componentName

if (componentName === 'TabItem') {
const paneName = (props && props.name) || (componentOptions && componentOptions.propsData.name)

orders.push(paneName)
}
}

tabVnodes.forEach(({ type, componentOptions, props, children }) => {
if (
type &&
(type.toString() === 'Symbol(Fragment)' || // vue@3.3之前的开发模式
type.toString() === 'Symbol(v-fgt)' || // vue@3.3.1 的变更
type.toString() === 'Symbol()') // 构建后
) {
Array.isArray(children) &&
children.forEach(({ type, componentOptions, props }) => handler({ type, componentOptions, props }))
} else {
handler({ type, componentOptions, props })
}
})
}

// 此处不同步aui,vue3情况下插槽使用v-if生成的slotDefault有差异
if (orders.length > 0) {
let tmpPanes = []

orders.forEach((paneName) => {
let pane = panes.find((pane) => pane.name === paneName)

if (pane) tmpPanes.push(pane)
})

panes = tmpPanes
}

return panes
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider refactoring getOrderedPanes to simplify and improve readability. The function has multiple nested conditions and could benefit from a more streamlined approach.

- const getOrderedPanes = (parent, panes) => { ... }
+ const getOrderedPanes = (parent, panes) => {
+   // Simplified logic here
+ }

Committable suggestion was skipped due low confidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants