fix(time-select): [time-select]After manually modifying the time, the initial time cannot be selected again.

[mengqiuleo]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: #2170

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Improved state management for time panel values by ensuring consistency between the current and last emitted values.

[coderabbitai]

Walkthrough

The changes in this pull request modify the initState function in the packages/renderless/src/time-panel/vue.ts file. The update specifically affects the setter for the value computed property, ensuring that both state.realValue and state.lastEmitValue are assigned the same valid value when applicable. This change enhances state management by keeping track of the last emitted value alongside the current value.

Changes

File Path	Change Summary
packages/renderless/src/time-panel/vue.ts	Modified initState function to update state.lastEmitValue alongside state.realValue when the value is valid.

Possibly related PRs

• refactor(time-select): [time-select] refactor the theme #2275: This PR involves refactoring the theme of the time-select component, which may relate to the changes in state management for the time panel in the main PR, as both are part of the time-related components.
• fix(time-picker): [time-picker] fixed a button style issue in the Sass theme #2330: This PR addresses a button style issue in the time-picker component, which is closely related to the time panel's functionality and state management, as both components are part of the time selection UI.
• test(e2e): [base-select,slider,time-select,tag,icon]fix e2e test error #2408: This PR focuses on fixing e2e test errors for the time-select component, which may indirectly relate to the changes in the main PR regarding state management and functionality of time-related components.

Suggested labels

bug

Suggested reviewers

• zzcr

🐰 In the meadow, where time does flow,
A change was made, a gentle glow.
Both values now, in sync they stay,
Last emitted, come what may.
A hop, a skip, the panel's bright,
Time's dance is now a pure delight! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/renderless/src/time-panel/vue.ts (1)

Line range hint 1-120: Add test coverage for the time reselection scenario.

Given this fixes a specific bug where initial time couldn't be reselected, we should add test coverage to prevent regression.

Would you like me to help create test cases that verify:

1. Initial time selection works
2. Manual time modification works
3. Reselection of initial time works after modification

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e7aa4a7 and a9edc38.

📒 Files selected for processing (1)

• packages/renderless/src/time-panel/vue.ts (1 hunks)

🔇 Additional comments (1)

packages/renderless/src/time-panel/vue.ts (1)

57-57: LGTM! The fix correctly synchronizes state.

The change ensures that lastEmitValue is synchronized with realValue when a valid time is selected, which should fix the issue of not being able to reselect the initial time.

Let's verify the state management logic:

✅ Verification successful

Based on the results, I can now generate the final response:

State synchronization is correctly implemented

The verification confirms that lastEmitValue is properly handled across the codebase:

• In vue.ts, it's synchronized with realValue during value updates
• In index.ts, it's used as expected in the emit logic to prevent duplicate emissions

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for other places where lastEmitValue might need similar synchronization

# Test 1: Check if lastEmitValue is properly handled in emitPick
rg -A 5 "lastEmitValue" 

# Test 2: Look for other state updates that might affect time selection
ast-grep --pattern 'state.realValue = $_'

Length of output: 1679