-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grid): [grid] inline pager add padding left #2449
Conversation
WalkthroughThe changes in this pull request introduce a new CSS rule in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/theme/src/grid/grid.less (1)
48-50
: Consider using a CSS custom property for the padding value.While the padding addition looks good, consider using a CSS custom property (CSS variable) instead of a hardcoded pixel value. This would make the padding configurable and maintain consistency with the theme system.
Here's how you could improve it:
+ // Define the variable in :root or an appropriate scope + --tv-grid-pager-left-padding: 8px; + & > .tiny-pager .tiny-pager__pull-left { - padding-left: 8px; + padding-left: var(--tv-grid-pager-left-padding); }This approach would:
- Allow for easy theme customization
- Maintain consistency with other spacing values
- Follow the existing pattern of using CSS custom properties in the codebase
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit