Rename TripTimeShort to TripTimeOnDate in method and class names

[vpaturet]

Summary

The class initially named TripTimeShort was renamed to TripTimeOnDate, but the method names and class names that refer to it were not updated, which is confusing.
This PR replaces all references to TripTimeShort by TripTimeOnDate.

Note: there are 2 related classes APITripTimeShort and ApiPatternShort in the REST API that are left untouched.

Issue

No

Unit tests

No

Documentation

No

[codecov]

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (c2b3d2c) to head (c7c3fa0).
Report is 66 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
.../opentripplanner/routing/TripTimeOnDateHelper.java	0.00%	2 Missing ⚠️
...apis/transmodel/model/plan/JourneyWhiteListed.java	0.00%	1 Missing ⚠️
...ripplanner/apis/transmodel/model/plan/LegType.java	75.00%	1 Missing ⚠️
...model/model/timetable/DatedServiceJourneyType.java	0.00%	1 Missing ⚠️
...transmodel/model/timetable/ServiceJourneyType.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #6042   +/-   ##
==========================================
  Coverage      69.74%   69.74%           
+ Complexity     17319    17318    -1     
==========================================
  Files           1960     1960           
  Lines          74268    74268           
  Branches        7603     7603           
==========================================
+ Hits           51795    51796    +1     
+ Misses         19831    19830    -1     
  Partials        2642     2642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.