-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full ISO times and colours to debug UI #6077
Add full ISO times and colours to debug UI #6077
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6077 +/- ##
=============================================
- Coverage 69.78% 69.78% -0.01%
+ Complexity 17357 17355 -2
=============================================
Files 1962 1962
Lines 74357 74357
Branches 7623 7623
=============================================
- Hits 51893 51892 -1
Misses 19820 19820
- Partials 2644 2645 +1 ☔ View full report in Codecov by Sentry. |
client/src/components/ItineraryList/useHeaderLegContentStyleCalculations.ts
Show resolved
Hide resolved
I noticed that the colors in the new Debug UI is in the same color palate as the OSM map - this is hard to "read" since it is little contrast. Should we do something about that? I think I can get a designer/UI person to look at this if intresting. |
Those colours are easy to change: OpenTripPlanner/client/src/util/getColorForMode.ts Lines 3 to 21 in 96b9004
|
One solution could also be to use a low-contrast background map. |
Do you want to explore the color palette further before merging this PR? I think you'll have a hard time finding a color palette that works well on top of this background map as @leonardehrenfried pointed out. |
I don't want to work on the colour palette and will do it in the next PR. We are now back to reading the colours from the transit data and will have to evaluate if that is better or worse. Another option would be to give the lines an outline. |
On the other hand it explains why the fallback colours in the old debug UI were so garish. |
Summary
This is a quality of life improvement for the debug UI:
title
property, so it shows up on hover