Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prune API #1058

Merged
merged 17 commits into from
Jul 5, 2023
Merged

Add Prune API #1058

merged 17 commits into from
Jul 5, 2023

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Jun 26, 2023 •
edited
Loading

Summary

  • Ticket no.112037
  • Support python api, project cli, cli for prune

How to test

I added some cli and unit tests about this feature.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex added the FEATURE New feature & functionality label Jun 26, 2023
@sooahleex sooahleex added this to the 1.4.0 milestone Jun 26, 2023
@openvinotoolkit openvinotoolkit deleted a comment from review-notebook-app bot Jun 27, 2023
@sooahleex sooahleex mentioned this pull request Jun 29, 2023
Merged
6 tasks
@sooahleex sooahleex marked this pull request as ready for review July 3, 2023 02:23
@sooahleex sooahleex requested review from a team as code owners July 3, 2023 02:23
vinnamkim
vinnamkim reviewed Jul 4, 2023
View reviewed changes
src/datumaro/cli/commands/prune.py Outdated Show resolved Hide resolved
src/datumaro/cli/commands/prune.py Outdated Show resolved Hide resolved
src/datumaro/cli/commands/prune.py Show resolved Hide resolved
src/datumaro/components/prune.py Outdated Show resolved Hide resolved
src/datumaro/components/prune.py Outdated Show resolved Hide resolved
src/datumaro/components/prune.py Outdated Show resolved Hide resolved
src/datumaro/components/prune.py Outdated Show resolved Hide resolved
vinnamkim
vinnamkim reviewed Jul 4, 2023
View reviewed changes
tests/unit/test_prune.py Outdated Show resolved Hide resolved
vinnamkim
vinnamkim reviewed Jul 5, 2023
View reviewed changes
tests/unit/test_prune.py Outdated Show resolved Hide resolved
vinnamkim
vinnamkim approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

wonjuleee
wonjuleee approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sooahleex sooahleex merged commit 9be801a into openvinotoolkit:develop Jul 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnamkim vinnamkim vinnamkim approved these changes

@wonjuleee wonjuleee wonjuleee approved these changes

@jihyeonyi jihyeonyi Awaiting requested review from jihyeonyi jihyeonyi is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@MarkByun MarkByun Awaiting requested review from MarkByun MarkByun is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@bonhunko bonhunko Awaiting requested review from bonhunko bonhunko is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
FEATURE New feature & functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sooahleex @vinnamkim @wonjuleee